Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250093003: Add unittest to GlRectDrawer (Closed)

Created:
5 years, 5 months ago by magjed_webrtc
Modified:
5 years, 5 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add unittest to GlRectDrawer Committed: https://crrev.com/b28678ce70d9e9f57ef50364f2054c4a1d630149 Cr-Commit-Position: refs/heads/master@{#9638}

Patch Set 1 #

Patch Set 2 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -1 line) Patch
A talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java View 1 1 chunk +138 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/EglBase.java View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250093003/1
5 years, 5 months ago (2015-07-23 15:22:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-23 16:53:40 UTC) #5
magjed_webrtc
Please take a look.
5 years, 5 months ago (2015-07-24 07:26:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250093003/20001
5 years, 5 months ago (2015-07-24 07:29:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-24 08:38:03 UTC) #10
AlexG
lgtm
5 years, 5 months ago (2015-07-24 19:37:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250093003/20001
5 years, 5 months ago (2015-07-26 11:28:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-26 12:17:23 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-26 12:17:34 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b28678ce70d9e9f57ef50364f2054c4a1d630149
Cr-Commit-Position: refs/heads/master@{#9638}

Powered by Google App Engine
This is Rietveld 408576698