Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1246083006: Median filter (Closed)

Created:
5 years, 5 months ago by magalhaesc
Modified:
5 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

If the array size is even, the median should be average of its two middlemost elements. NADA unittests updated accordingly. BUG=webrtc:4550 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/496019c5961cdda13181ff51a3abf0d09d315cc4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
magalhaesc
Minor change on NADA::MedianFilter https://codereview.webrtc.org/1246083006/diff/1/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc File webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc (right): https://codereview.webrtc.org/1246083006/diff/1/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc#newcode134 webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc:134: if (size % 2 == ...
5 years, 5 months ago (2015-07-22 09:01:11 UTC) #2
stefan-webrtc
lgtm https://codereview.webrtc.org/1246083006/diff/1/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc File webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc (right): https://codereview.webrtc.org/1246083006/diff/1/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc#newcode132 webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc:132: array_copy.end()); Move this inside the if statement.
5 years, 5 months ago (2015-07-22 09:21:19 UTC) #3
magalhaesc
Comment addressed
5 years, 5 months ago (2015-07-22 09:23:56 UTC) #4
magalhaesc
5 years, 5 months ago (2015-07-22 09:30:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
496019c5961cdda13181ff51a3abf0d09d315cc4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698