Remove CircularFileStream / replace it with CallSessionFileRotatingStream.

Remove CircularFileStream / replace it with CallSessionFileRotatingStream.

BUG=4838, 4839
Committed: https://crrev.com/28bae02bd383abbd35cc87fa1188a569f1b3c683
Cr-Commit-Position: refs/heads/master@{#9628}

[tkchin_webrtc, 2015-07-22 20:30:33]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2015-07-22 20:36:14]

tkchin@webrtc.org changed reviewers:
+ jiayl@webrtc.org

[tkchin_webrtc, 2015-07-22 20:48:55]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2015-07-22 20:49:03]

Patchset #1 (id:30001) has been deleted

[jiayl2, 2015-07-22 21:17:33]

https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
File talk/app/webrtc/objc/RTCFileLogger.mm (right):

https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
talk/app/webrtc/objc/RTCFileLogger.mm:134: } while (read > 0);
Do we need the loop because ReadAll may exit when reading one file returns an
error, but we want to continue reading?
I think a cleaner way is to override ReadAll in FireRotatingStream, so this
class does not need to loop.

[tkchin_webrtc, 2015-07-22 23:01:40]

https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
File talk/app/webrtc/objc/RTCFileLogger.mm (right):

https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
talk/app/webrtc/objc/RTCFileLogger.mm:134: } while (read > 0);
On 2015/07/22 21:17:33, jiayl2 wrote:
> Do we need the loop because ReadAll may exit when reading one file returns an
> error, but we want to continue reading?
> I think a cleaner way is to override ReadAll in FireRotatingStream, so this
> class does not need to loop.

No, it's because the buffer may be too big or too small. If too big ReadAll
returns EOS with #bytes read. If too small and not done we need to continue.

We could also implement GetSize so we can allocate correctly. wdyt?

[jiayl2, 2015-07-22 23:35:01]

lgtm

https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
File talk/app/webrtc/objc/RTCFileLogger.mm (right):

https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
talk/app/webrtc/objc/RTCFileLogger.mm:134: } while (read > 0);
On 2015/07/22 23:01:39, tkchin_webrtc wrote:
> On 2015/07/22 21:17:33, jiayl2 wrote:
> > Do we need the loop because ReadAll may exit when reading one file returns
an
> > error, but we want to continue reading?
> > I think a cleaner way is to override ReadAll in FireRotatingStream, so this
> > class does not need to loop.
> 
> No, it's because the buffer may be too big or too small. If too big ReadAll
> returns EOS with #bytes read. If too small and not done we need to continue.
> 
> We could also implement GetSize so we can allocate correctly. wdyt?

Ah, I see. I think this is fine.

[tkchin_webrtc, 2015-07-23 00:44:45]

Patchset #2 (id:70001) has been deleted

[tkchin_webrtc, 2015-07-23 00:54:32]

Patchset #2 (id:90001) has been deleted

[tkchin_webrtc, 2015-07-23 00:59:50]

Patchset #2 (id:110001) has been deleted

[tkchin_webrtc, 2015-07-23 01:01:22]

On 2015/07/22 23:35:01, jiayl2 wrote:
> lgtm
> 
>
https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
> File talk/app/webrtc/objc/RTCFileLogger.mm (right):
> 
>
https://codereview.webrtc.org/1245143005/diff/50001/talk/app/webrtc/objc/RTCF...
> talk/app/webrtc/objc/RTCFileLogger.mm:134: } while (read > 0);
> On 2015/07/22 23:01:39, tkchin_webrtc wrote:
> > On 2015/07/22 21:17:33, jiayl2 wrote:
> > > Do we need the loop because ReadAll may exit when reading one file returns
> an
> > > error, but we want to continue reading?
> > > I think a cleaner way is to override ReadAll in FireRotatingStream, so
this
> > > class does not need to loop.
> > 
> > No, it's because the buffer may be too big or too small. If too big ReadAll
> > returns EOS with #bytes read. If too small and not done we need to continue.
> > 
> > We could also implement GetSize so we can allocate correctly. wdyt?
> 
> Ah, I see. I think this is fine.

PTAL

didn't see your message, had already added it since it was small.

[jiayl2, 2015-07-23 16:13:42]

lgtm

[tkchin_webrtc, 2015-07-23 18:47:31]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2015-07-23 18:47:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245143005/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1245143005/130001

[commit-bot: I haz the power, 2015-07-23 19:27:05]

Committed patchset #2 (id:130001)

[commit-bot: I haz the power, 2015-07-23 19:27:14]

Patchset 2 (id:??) landed as
https://crrev.com/28bae02bd383abbd35cc87fa1188a569f1b3c683
Cr-Commit-Position: refs/heads/master@{#9628}