Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: talk/app/webrtc/objc/public/RTCFileLogger.h

Issue 1245143005: Remove CircularFileStream / replace it with CallSessionFileRotatingStream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add GetSize to FileRotatingStream Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/objc/RTCFileLogger.mm ('k') | webrtc/base/filerotatingstream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/objc/public/RTCFileLogger.h
diff --git a/talk/app/webrtc/objc/public/RTCFileLogger.h b/talk/app/webrtc/objc/public/RTCFileLogger.h
index 5c311b711a2f5718403a9846330d5e0c6dec2a6a..3900cb6fbeb5199913be877f246b3677ba1c6aae 100644
--- a/talk/app/webrtc/objc/public/RTCFileLogger.h
+++ b/talk/app/webrtc/objc/public/RTCFileLogger.h
@@ -49,24 +49,22 @@ typedef NS_ENUM(NSUInteger, RTCFileLoggerSeverity) {
// The severity level to capture. The default is kRTCFileLoggerSeverityInfo.
@property(nonatomic, assign) RTCFileLoggerSeverity severity;
-// Default constructor provides default settings for file path and file size.
+// Default constructor provides default settings for dir path and file size.
- (instancetype)init;
-- (instancetype)initWithFilePath:(NSString *)filePath
- maxFileSize:(NSUInteger)maxFileSize
+- (instancetype)initWithDirPath:(NSString *)dirPath
+ maxFileSize:(NSUInteger)maxFileSize
NS_DESIGNATED_INITIALIZER;
-// Starts writing WebRTC logs to file if not already started. Overwrites any
-// existing file.
+// Starts writing WebRTC logs to disk if not already started. Overwrites any
+// existing file(s).
- (void)start;
-// Stops writing WebRTC logs to file. Rewrites the log file as required to
-// reorder logs because logs may be disordered due to use of
-// rtc::CircularFileStream. This method is also called on dealloc.
+// Stops writing WebRTC logs to disk. This method is also called on dealloc.
- (void)stop;
-// Returns the current contents of the log file. Returns nil if start has been
-// called without a stop, or if there is no data.
+// Returns the current contents of the logs, or nil if start has been called
+// without a stop.
- (NSData *)logData;
@end
« no previous file with comments | « talk/app/webrtc/objc/RTCFileLogger.mm ('k') | webrtc/base/filerotatingstream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698