Issue 1244383003: [NOT FOR REVIEW] Various changes requested by Andrew

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1244383003: [NOT FOR REVIEW] Various changes requested by Andrew (Closed)

Created:
5 years, 5 months ago by Peter Kasting

Modified:
5 years, 3 months ago

Reviewers:

CC:
aluebs-webrtc, Andrew MacDonald, bjornv1, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, webrtc-reviews_webrtc.org

Base URL:
https://chromium.googlesource.com/external/webrtc@size_t

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Various changes requested by Andrew BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Resync #

Patch Set 3 : Android work #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+256 lines, -362 lines)			Patch
M	webrtc/common_audio/signal_processing/auto_correlation.c	View		2 chunks	+9 lines, -10 lines	0 comments	Download
M	webrtc/common_audio/signal_processing/include/signal_processing_library.h	View		12 chunks	+19 lines, -40 lines	0 comments	Download
M	webrtc/common_audio/signal_processing/min_max_operations.c	View		13 chunks	+24 lines, -45 lines	0 comments	Download
M	webrtc/common_audio/signal_processing/min_max_operations_mips.c	View		7 chunks	+9 lines, -18 lines	0 comments	Download
M	webrtc/common_audio/signal_processing/min_max_operations_neon.c	View		7 chunks	+7 lines, -18 lines	0 comments	Download
M	webrtc/common_audio/signal_processing/signal_processing_unittest.cc	View		5 chunks	+11 lines, -48 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/cb_search_core.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/constants.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/constants.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/defines.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/enhancer.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/enhancer.c	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c	View		8 chunks	+19 lines, -19 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/frame_classify.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/get_sync_seq.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/get_sync_seq.c	View		2 chunks	+30 lines, -30 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/nearest_neighbor.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/nearest_neighbor.c	View		1 chunk	+8 lines, -7 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/refiner.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	webrtc/modules/audio_coding/codecs/ilbc/refiner.c	View		2 chunks	+45 lines, -56 lines	0 comments	Download
M	webrtc/modules/audio_coding/neteq/expand.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	webrtc/modules/audio_device/android/audio_manager.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	webrtc/modules/audio_device/android/audio_manager_unittest.cc	View	1 2	4 chunks	+8 lines, -7 lines	0 comments	Download
M	webrtc/modules/audio_device/android/fine_audio_buffer.h	View	1 2	3 chunks	+7 lines, -7 lines	0 comments	Download
M	webrtc/modules/audio_device/android/fine_audio_buffer.cc	View	1 2	4 chunks	+9 lines, -9 lines	0 comments	Download
M	webrtc/modules/audio_device/android/opensles_player.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webrtc/modules/audio_device/android/opensles_player.cc	View	1 2	4 chunks	+8 lines, -6 lines	0 comments	Download
M	webrtc/modules/audio_device/include/audio_device_defines.h	View	1 2	2 chunks	+8 lines, -8 lines	0 comments	Download
M	webrtc/modules/audio_device/ios/audio_device_ios.mm	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1230503003 Patch 60001