[NOT FOR REVIEW] Various changes requested by Andrew

webrtc/modules/audio_coding/codecs/ilbc/nearest_neighbor.c

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 /******************************************************************
 
  iLBC Speech Coder ANSI-C Source Code
 
  WebRtcIlbcfix_NearestNeighbor.c
 
 ******************************************************************/
 
 #include "defines.h"
 
 /*----------------------------------------------------------------*
  * Find index in array such that the array element with said
  * index is the element of said array closest to "value"
  * according to the squared-error criterion
  *---------------------------------------------------------------*/
 
 void WebRtcIlbcfix_NearestNeighbor(
-    int16_t *index, /* (o) index of array element closest to value */
-    int16_t *array, /* (i) data array (Q2) */
-    int16_t value, /* (i) value (Q2) */
+    size_t *index, /* (o) index of array element closest to value */
+    const size_t *array, /* (i) data array (Q2) */
+    size_t value, /* (i) value (Q2) */
     size_t arlength /* (i) dimension of data array (==8) */
                                    ){
   size_t i;
-  int16_t diff;
+  int32_t signed_value = (int32_t)value;
+  int32_t diff;
   /* Stack based */
   int32_t crit[8];
 
   /* Calculate square distance */
-  for(i=0;i<arlength;i++){
-    diff=array[i]-value;
+  for (i = 0; i < arlength; i++) {
+    diff = (int32_t)array[i] - signed_value;
     crit[i] = diff * diff;
   }
 
   /* Find the minimum square distance */
-  *index=WebRtcSpl_MinIndexW32(crit, arlength);
+  *index = WebRtcSpl_MinIndexW32(crit, arlength);
 }