Fix an NPE.

Fix an NPE when creating TurnPort with a NULL socket.

BUG=4827
Committed: https://crrev.com/f421bdc68dbf8ab456d36909185b6b2a8935bc64
Cr-Commit-Position: refs/heads/master@{#9601}

[honghaiz3, 2015-07-15 20:43:06]

honghaiz@webrtc.org changed reviewers:
+ guoweis@webrtc.org

[honghaiz3, 2015-07-15 20:43:06]

There are also issues in tcp ports. Will fix them in separate CLs.

[guoweis_webrtc, 2015-07-15 21:18:31]

On 2015/07/15 20:43:06, honghaiz3 wrote:
> There are also issues in tcp ports. Will fix them in separate CLs.

tcp port doesn't have the concept of shared socket. But if it could lead to a
crash, please also address them.

I think this is small and also given this code will change later, a test is not
needed. 

lgtm from me but please also get Peter to review. He's one of the owners to
allow check in.

[honghaiz3, 2015-07-15 22:15:58]

honghaiz@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[honghaiz3, 2015-07-15 22:16:12]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 22:16:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241943002/1

[commit-bot: I haz the power, 2015-07-15 23:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 23:13:04]

Dry run: This issue passed the CQ dry run.

[pthatcher1, 2015-07-15 23:46:25]

Can you add a test that would pass in a NULL socket and cause a crash in the
test if we don't have this fix?  I think as we refactor this code in the future,
it will be easy to forget about this an re-introduce the crash if we don't have
a test.

[honghaiz3, 2015-07-17 18:52:17]

Patchset #2 (id:20001) has been deleted

[honghaiz3, 2015-07-17 18:53:10]

On 2015/07/15 23:46:25, pthatcher1 wrote:
> Can you add a test that would pass in a NULL socket and cause a crash in the
> test if we don't have this fix?  I think as we refactor this code in the
future,
> it will be easy to forget about this an re-introduce the crash if we don't
have
> a test.
Added tests.

[honghaiz3, 2015-07-17 18:55:06]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 18:55:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241943002/40001

[commit-bot: I haz the power, 2015-07-17 19:38:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 19:38:43]

Dry run: This issue passed the CQ dry run.

[pthatcher1, 2015-07-17 21:40:24]

lgtm

https://codereview.webrtc.org/1241943002/diff/40001/webrtc/p2p/client/portall...
File webrtc/p2p/client/portallocator_unittest.cc (right):

https://codereview.webrtc.org/1241943002/diff/40001/webrtc/p2p/client/portall...
webrtc/p2p/client/portallocator_unittest.cc:1081: // AllocationSequence is null.
Can you explain how we end up with a null socket_ in the test?  It isn't obvious
to me.

[honghaiz3, 2015-07-17 22:38:53]

On 2015/07/17 21:40:24, pthatcher1 wrote:
> lgtm
> 
>
https://codereview.webrtc.org/1241943002/diff/40001/webrtc/p2p/client/portall...
> File webrtc/p2p/client/portallocator_unittest.cc (right):
> 
>
https://codereview.webrtc.org/1241943002/diff/40001/webrtc/p2p/client/portall...
> webrtc/p2p/client/portallocator_unittest.cc:1081: // AllocationSequence is
null.
> Can you explain how we end up with a null socket_ in the test?  It isn't
obvious
> to me.
Null value is chosen in the constructor. Slightly modified the comments.

[honghaiz3, 2015-07-17 22:39:13]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2015-07-17 22:39:14]

The patchset sent to the CQ was uploaded after l-g-t-m from guoweis@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1241943002/#ps60001 (title:
"Updated the comments.")

[commit-bot: I haz the power, 2015-07-17 22:39:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241943002/60001

[honghaiz3, 2015-07-17 22:50:50]

The CQ bit was unchecked by honghaiz@webrtc.org

[honghaiz3, 2015-07-17 22:51:27]

The CQ bit was checked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2015-07-17 22:51:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241943002/60001

[commit-bot: I haz the power, 2015-07-17 23:21:59]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-07-17 23:22:09]

Patchset 3 (id:??) landed as
https://crrev.com/f421bdc68dbf8ab456d36909185b6b2a8935bc64
Cr-Commit-Position: refs/heads/master@{#9601}