Fix an NPE.

webrtc/p2p/client/portallocator_unittest.cc

 /*
  *  Copyright 2009 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/p2p/base/basicpacketsocketfactory.h"
 #include "webrtc/p2p/base/constants.h"
 #include "webrtc/p2p/base/p2ptransportchannel.h"
 #include "webrtc/p2p/base/testrelayserver.h"
 #include "webrtc/p2p/base/teststunserver.h"
 #include "webrtc/p2p/base/testturnserver.h"
 #include "webrtc/p2p/client/basicportallocator.h"
 #include "webrtc/p2p/client/httpportallocator.h"
 #include "webrtc/base/fakenetwork.h"
 #include "webrtc/base/firewallsocketserver.h"
 #include "webrtc/base/gunit.h"
 #include "webrtc/base/helpers.h"
+#include "webrtc/base/ipaddress.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/natserver.h"
 #include "webrtc/base/natsocketfactory.h"
 #include "webrtc/base/network.h"
 #include "webrtc/base/physicalsocketserver.h"
 #include "webrtc/base/socketaddress.h"
 #include "webrtc/base/ssladapter.h"
 #include "webrtc/base/thread.h"
 #include "webrtc/base/virtualsocketserver.h"
 
@@ skipping 1012 matching lines @@
   EXPECT_TRUE(CreateSession(cricket::ICE_CANDIDATE_COMPONENT_RTP));
   session_->StartGettingPorts();
   ASSERT_EQ_WAIT(7U, candidates_.size(), kDefaultAllocationTimeout);
   EXPECT_EQ(4U, ports_.size());
 
   auto it = ports_.begin();
   for (; it != ports_.end(); ++it) {
     (reinterpret_cast<cricket::Port*>(*it))->Destroy();
   }
 }
+
+class AllocationSequenceForTest : public cricket::AllocationSequence {
+ public:
+  AllocationSequenceForTest(cricket::BasicPortAllocatorSession* session,
+                            rtc::Network* network,
+                            cricket::PortConfiguration* config,
+                            uint32 flags)
+      : cricket::AllocationSequence(session, network, config, flags) {}
+  using cricket::AllocationSequence::CreateTurnPort;
+};
+
+TEST_F(PortAllocatorTest, TestCreateTurnPortWithNullSocket) {
+  EXPECT_TRUE(CreateSession(cricket::ICE_CANDIDATE_COMPONENT_RTP));
+  session_->StartGettingPorts();
+
+  cricket::ServerAddresses stun_servers;
+  stun_servers.insert(kStunAddr);
+  cricket::PortConfiguration config(stun_servers, kIceUfrag0, kIcePwd0);
+  rtc::Network network1("test_eth0", "Test Network Adapter 1",
+                        rtc::IPAddress(0x12345600U), 24);
+  uint32 flag = cricket::PORTALLOCATOR_ENABLE_SHARED_SOCKET;
+  AllocationSequenceForTest alloc_sequence(
+      static_cast<cricket::BasicPortAllocatorSession*>(session_.get()),
+      &network1, &config, flag);
+  // This simply tests it will not crash if udp_socket_ in the
+  // AllocationSequence is null, which is chosen in the constructor.
+  cricket::RelayServerConfig relay_server(cricket::RELAY_TURN);
+  relay_server.ports.push_back(
+      cricket::ProtocolAddress(kTurnUdpIntAddr, cricket::PROTO_UDP, false));
+  alloc_sequence.CreateTurnPort(relay_server);
+}