Remove deprecated functions.

Remove deprecated functions.

This CL removes some functions that are marked as deprecated. Chromium
has been updated in https://crrev.com/7dee3f68b7699ad72c7fc4d75332f72703313849
to call the new functions.

Committed: https://crrev.com/fabe2c961f9cf86d519532a96e96fa7d6c4ca37d
Cr-Commit-Position: refs/heads/master@{#9598}

[joachim, 2015-07-15 21:32:06]

jbauch@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[joachim, 2015-07-15 21:32:06]

PTAL

[pthatcher1, 2015-07-16 04:41:31]

lgtm, with a minor fix.

https://codereview.webrtc.org/1237613003/diff/20001/talk/examples/peerconnect...
File talk/examples/peerconnection/client/conductor.cc (right):

https://codereview.webrtc.org/1237613003/diff/20001/talk/examples/peerconnect...
talk/examples/peerconnection/client/conductor.cc:306:
webrtc::CreateSessionDescription(type, sdp, nullptr));
Can you introduce a local variable to give the value a name, to make the code
more readable?

SdpParseError error;
webrtc::SessionDescriptionInterface* session_description(
  webrtc::CreateSessionDescription(type, sdp, &error));

[joachim, 2015-07-16 08:12:01]

https://codereview.webrtc.org/1237613003/diff/20001/talk/examples/peerconnect...
File talk/examples/peerconnection/client/conductor.cc (right):

https://codereview.webrtc.org/1237613003/diff/20001/talk/examples/peerconnect...
talk/examples/peerconnection/client/conductor.cc:306:
webrtc::CreateSessionDescription(type, sdp, nullptr));
On 2015/07/16 04:41:31, pthatcher1 wrote:
> Can you introduce a local variable to give the value a name, to make the code
> more readable?
> 
> SdpParseError error;
> webrtc::SessionDescriptionInterface* session_description(
>   webrtc::CreateSessionDescription(type, sdp, &error));

Done, also changed to log the error description.

[joachim, 2015-07-16 08:44:08]

The CQ bit was checked by jbauch@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-16 08:44:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237613003/40001

[commit-bot: I haz the power, 2015-07-16 08:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 08:46:56]

Dry run: Try jobs failed on following builders:
  ios_arm64 on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64/builds/3446)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/7188)

(exceeded global retry quota)

[joachim, 2015-07-16 11:40:38]

The CQ bit was checked by jbauch@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-16 11:40:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237613003/60001

[commit-bot: I haz the power, 2015-07-16 12:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 12:53:36]

Dry run: This issue passed the CQ dry run.

[joachim, 2015-07-16 20:41:34]

The CQ bit was checked by jbauch@webrtc.org

[joachim, 2015-07-16 20:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1237613003/#ps60001 (title:
"Call new function from objc.")

[commit-bot: I haz the power, 2015-07-16 20:41:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237613003/60001

[commit-bot: I haz the power, 2015-07-16 20:43:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-16 20:43:39]

Patchset 4 (id:??) landed as
https://crrev.com/fabe2c961f9cf86d519532a96e96fa7d6c4ca37d
Cr-Commit-Position: refs/heads/master@{#9598}