Remove deprecated functions.

talk/examples/peerconnection/client/conductor.cc

 /*
  * libjingle
  * Copyright 2012 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 285 matching lines @@
       return;
     }
 
     std::string sdp;
     if (!rtc::GetStringFromJsonObject(jmessage, kSessionDescriptionSdpName,
                                       &sdp)) {
       LOG(WARNING) << "Can't parse received session description message.";
       return;
     }
     webrtc::SessionDescriptionInterface* session_description(
-        webrtc::CreateSessionDescription(type, sdp));
+        webrtc::CreateSessionDescription(type, sdp, nullptr));

[pthatcher1, 2015/07/16 04:41:31]

Can you introduce a local variable to give the value a name, to make the code
more readable?

SdpParseError error;
webrtc::SessionDescriptionInterface* session_description(
  webrtc::CreateSessionDescription(type, sdp, &error));

[joachim, 2015/07/16 08:12:00]

Done, also changed to log the error description.

     if (!session_description) {
       LOG(WARNING) << "Can't parse received session description message.";
       return;
     }
     LOG(INFO) << " Received session description :" << message;
     peer_connection_->SetRemoteDescription(
         DummySetSessionDescriptionObserver::Create(), session_description);
     if (session_description->type() ==
         webrtc::SessionDescriptionInterface::kOffer) {
       peer_connection_->CreateAnswer(this, NULL);
     }
     return;
   } else {
     std::string sdp_mid;
     int sdp_mlineindex = 0;
     std::string sdp;
     if (!rtc::GetStringFromJsonObject(jmessage, kCandidateSdpMidName,
                                       &sdp_mid) ||
         !rtc::GetIntFromJsonObject(jmessage, kCandidateSdpMlineIndexName,
                                    &sdp_mlineindex) ||
         !rtc::GetStringFromJsonObject(jmessage, kCandidateSdpName, &sdp)) {
       LOG(WARNING) << "Can't parse received message.";
       return;
     }
     rtc::scoped_ptr<webrtc::IceCandidateInterface> candidate(
-        webrtc::CreateIceCandidate(sdp_mid, sdp_mlineindex, sdp));
+        webrtc::CreateIceCandidate(sdp_mid, sdp_mlineindex, sdp, nullptr));
     if (!candidate.get()) {
       LOG(WARNING) << "Can't parse received candidate message.";
       return;
     }
     if (!peer_connection_->AddIceCandidate(candidate.get())) {
       LOG(WARNING) << "Failed to apply the received candidate";
       return;
     }
     LOG(INFO) << " Received candidate :" << message;
     return;
@@ skipping 186 matching lines @@
   peer_connection_->SetLocalDescription(
       DummySetSessionDescriptionObserver::Create(), desc);
 
   std::string sdp;
   desc->ToString(&sdp);
 
   // For loopback test. To save some connecting delay.
   if (loopback_) {
     // Replace message type from "offer" to "answer"
     webrtc::SessionDescriptionInterface* session_description(
-        webrtc::CreateSessionDescription("answer", sdp));
+        webrtc::CreateSessionDescription("answer", sdp, nullptr));
     peer_connection_->SetRemoteDescription(
         DummySetSessionDescriptionObserver::Create(), session_description);
     return;
   }
 
   Json::StyledWriter writer;
   Json::Value jmessage;
   jmessage[kSessionDescriptionTypeName] = desc->type();
   jmessage[kSessionDescriptionSdpName] = sdp;
   SendMessage(writer.write(jmessage));
 }
 
 void Conductor::OnFailure(const std::string& error) {
     LOG(LERROR) << error;
 }
 
 void Conductor::SendMessage(const std::string& json_object) {
   std::string* msg = new std::string(json_object);
   main_wnd_->QueueUIThreadCallback(SEND_MESSAGE_TO_PEER, msg);
 }