Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1231273004: Base padding bitrate for an encoder on the bitrate allocated for that encoder, rather than the tota… (Closed)

Created:
5 years, 5 months ago by stefan-webrtc
Modified:
5 years, 5 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Base padding bitrate for an encoder on the bitrate allocated for that encoder, rather than the total bitrate of the channel group. Committed: https://crrev.com/a4a8d4ad27bd0bd7a6cc5df697951d4531ddb4ee Cr-Commit-Position: refs/heads/master@{#9584}

Patch Set 1 #

Patch Set 2 : Format. #

Patch Set 3 : move some code around #

Total comments: 4

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M webrtc/video_engine/vie_channel_group.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
stefan-webrtc
move some code around
5 years, 5 months ago (2015-07-15 09:59:45 UTC) #1
stefan-webrtc
5 years, 5 months ago (2015-07-15 10:00:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231273004/40001
5 years, 5 months ago (2015-07-15 10:01:06 UTC) #5
pbos-webrtc
lgtm, but fix yo shit https://codereview.webrtc.org/1231273004/diff/40001/webrtc/video_engine/vie_encoder.cc File webrtc/video_engine/vie_encoder.cc (right): https://codereview.webrtc.org/1231273004/diff/40001/webrtc/video_engine/vie_encoder.cc#newcode416 webrtc/video_engine/vie_encoder.cc:416: git cl format, yo.
5 years, 5 months ago (2015-07-15 10:52:36 UTC) #6
pbos-webrtc
https://codereview.webrtc.org/1231273004/diff/40001/webrtc/video_engine/vie_channel_group.cc File webrtc/video_engine/vie_channel_group.cc (right): https://codereview.webrtc.org/1231273004/diff/40001/webrtc/video_engine/vie_channel_group.cc#newcode477 webrtc/video_engine/vie_channel_group.cc:477: for (const auto& encoder : send_encoders_) { remove {}s
5 years, 5 months ago (2015-07-15 10:53:35 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-15 10:54:02 UTC) #9
stefan-webrtc
Addressed comments
5 years, 5 months ago (2015-07-15 10:54:33 UTC) #10
stefan-webrtc
https://codereview.webrtc.org/1231273004/diff/40001/webrtc/video_engine/vie_channel_group.cc File webrtc/video_engine/vie_channel_group.cc (right): https://codereview.webrtc.org/1231273004/diff/40001/webrtc/video_engine/vie_channel_group.cc#newcode477 webrtc/video_engine/vie_channel_group.cc:477: for (const auto& encoder : send_encoders_) { On 2015/07/15 ...
5 years, 5 months ago (2015-07-15 10:54:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231273004/60001
5 years, 5 months ago (2015-07-15 10:55:39 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-15 11:39:30 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 11:39:40 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a4a8d4ad27bd0bd7a6cc5df697951d4531ddb4ee
Cr-Commit-Position: refs/heads/master@{#9584}

Powered by Google App Engine
This is Rietveld 408576698