Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1227893002: Update audio code to use size_t more correctly, webrtc/ portion. (Closed)

Created:
5 years, 5 months ago by Peter Kasting
Modified:
5 years, 4 months ago
CC:
Andrew MacDonald, henrika_webrtc, interface-changes_webrtc.org, mflodman, niklas.enbom, qiang.lu, rwolff_gocast.it, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update audio code to use size_t more correctly, webrtc/ portion. This is a piece of https://codereview.webrtc.org/1230503003 , split out to a separate change to make reviewing easier. BUG=chromium:81439 TEST=none

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M webrtc/common_types.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/interface/aligned_array.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/system_wrappers/source/aligned_array_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/test/fake_audio_device.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_audio_device.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M webrtc/tools/agc/activity_metric.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M webrtc/tools/agc/agc_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/tools/agc/agc_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/agc/test_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Kasting
5 years, 5 months ago (2015-07-09 22:41:39 UTC) #2
Peter Kasting
-> henrika
5 years, 5 months ago (2015-07-11 08:31:16 UTC) #4
henrika_webrtc
5 years, 5 months ago (2015-07-13 08:01:48 UTC) #6
pbos-webrtc
https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interface/aligned_array.h File webrtc/system_wrappers/interface/aligned_array.h (right): https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interface/aligned_array.h#newcode23 webrtc/system_wrappers/interface/aligned_array.h:23: AlignedArray(int rows, size_t cols, int alignment) size_t for row ...
5 years, 5 months ago (2015-07-13 08:13:30 UTC) #7
Peter Kasting
https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interface/aligned_array.h File webrtc/system_wrappers/interface/aligned_array.h (right): https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interface/aligned_array.h#newcode23 webrtc/system_wrappers/interface/aligned_array.h:23: AlignedArray(int rows, size_t cols, int alignment) On 2015/07/13 at ...
5 years, 5 months ago (2015-07-16 23:59:43 UTC) #8
pbos-webrtc
On 2015/07/16 23:59:43, Peter Kasting wrote: > https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interface/aligned_array.h > File webrtc/system_wrappers/interface/aligned_array.h (right): > > https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interface/aligned_array.h#newcode23 ...
5 years, 5 months ago (2015-07-17 04:02:27 UTC) #9
pbos-webrtc
5 years, 5 months ago (2015-07-17 04:02:30 UTC) #10
On 2015/07/16 23:59:43, Peter Kasting wrote:
>
https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interf...
> File webrtc/system_wrappers/interface/aligned_array.h (right):
> 
>
https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/interf...
> webrtc/system_wrappers/interface/aligned_array.h:23: AlignedArray(int rows,
> size_t cols, int alignment)
> On 2015/07/13 at 08:13:30, pbos-webrtc wrote:
> > size_t for row and alignment as well?
> 
> Yes, but doing this properly involves converting channel counts to size_t,
which
> is another big change: see https://codereview.webrtc.org/1238083005 for that. 
> So I'll leave this as-is in this change (both in this small piece and in the
> larger merged version) and then make that other change after all this stuff
> lands.
> 
>
https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/source...
> File webrtc/system_wrappers/source/aligned_array_unittest.cc (right):

That's fine by me, thanks for fixing the follow-up as well. lgtm. :)

>
https://codereview.webrtc.org/1227893002/diff/1/webrtc/system_wrappers/source...
> webrtc/system_wrappers/source/aligned_array_unittest.cc:57:
> ASSERT_EQ(arr.cols(), 7U);
> On 2015/07/13 at 08:13:30, pbos-webrtc wrote:
> > 7u imo, not going to be annoying about it
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698