Update audio code to use size_t more correctly, webrtc/modules/audio_processing/

webrtc/modules/audio_processing/beamformer/matrix.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 77 matching lines @@
   void CopyFrom(const Matrix& other) {
     CopyFrom(&other.data_[0], other.num_rows_, other.num_columns_);
   }
 
   // Copy |data| into the Matrix. The current data is lost.
   void CopyFrom(const T* const data, int num_rows, int num_columns) {
     Resize(num_rows, num_columns);
     memcpy(&data_[0], data, num_rows_ * num_columns_ * sizeof(data_[0]));
   }
 
-  Matrix& CopyFromColumn(const T* const* src, int column_index, int num_rows) {
+  Matrix& CopyFromColumn(const T* const* src,
+                         size_t column_index,
+                         int num_rows) {

[Andrew MacDonald, 2015/07/24 04:01:43]

num_rows should be size_t

[Peter Kasting, 2015/07/24 06:44:22]

That's also part of the followup: https://codereview.webrtc.org/1238083005

[Andrew MacDonald, 2015/07/24 19:07:13]

Acknowledged.

     Resize(1, num_rows);
     for (int i = 0; i < num_columns_; ++i) {
       data_[i] = src[i][column_index];
     }
 
     return *this;
   }
 
   void Resize(int num_rows, int num_columns) {

[Andrew MacDonald, 2015/07/24 04:01:43]

And here, and everywhere else we have num_rows/num_columns.

Was your intent to try to convert everything?

[Peter Kasting, 2015/07/24 06:44:22]

No!  Seriously, it would literally be impossible to do or to land.

Same response for the rest of the channel count places you point out.

[Andrew MacDonald, 2015/07/24 19:07:13]

Acknowledged.

     if (num_rows != num_rows_ || num_columns != num_columns_) {
       num_rows_ = num_rows;
       num_columns_ = num_columns;
       Resize();
     }
   }
 
   // Accessors and mutators.
   int num_rows() const { return num_rows_; }
   int num_columns() const { return num_columns_; }
@@ skipping 239 matching lines @@
 
     return *this;
   }
 
   DISALLOW_COPY_AND_ASSIGN(Matrix);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_BEAMFORMER_MATRIX_H_