Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove distinction between send and receive NACK. Allow disabling receive-side. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h
index 98f7c26b553ee7f67ee53e120df977dfcbba43a9..6cb1375fe9d77eb623640317dfea17c60ec7f008 100644
--- a/webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h
@@ -600,19 +600,15 @@ class RtpRtcp : public Module {
/*
* Turn on/off generic FEC
- *
- * return -1 on failure else 0
*/
- virtual int32_t SetGenericFECStatus(bool enable,
- uint8_t payloadTypeRED,
- uint8_t payloadTypeFEC) = 0;
+ virtual void SetGenericFECStatus(bool enable,
+ uint8_t payload_type_red,
+ uint8_t payload_type_fec) = 0;
/*
* Get generic FEC setting
- *
- * return -1 on failure else 0
*/
- virtual int32_t GenericFECStatus(bool& enable,
+ virtual void GenericFECStatus(bool& enable,
uint8_t& payloadTypeRED,
uint8_t& payloadTypeFEC) = 0;

Powered by Google App Engine
This is Rietveld 408576698