Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove distinction between send and receive NACK. Allow disabling receive-side. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
593 * 593 *
594 ***************************************************************************/ 594 ***************************************************************************/
595 595
596 /* 596 /*
597 * Set the target send bitrate 597 * Set the target send bitrate
598 */ 598 */
599 virtual void SetTargetSendBitrate(uint32_t bitrate_bps) = 0; 599 virtual void SetTargetSendBitrate(uint32_t bitrate_bps) = 0;
600 600
601 /* 601 /*
602 * Turn on/off generic FEC 602 * Turn on/off generic FEC
603 *
604 * return -1 on failure else 0
605 */ 603 */
606 virtual int32_t SetGenericFECStatus(bool enable, 604 virtual void SetGenericFECStatus(bool enable,
607 uint8_t payloadTypeRED, 605 uint8_t payload_type_red,
608 uint8_t payloadTypeFEC) = 0; 606 uint8_t payload_type_fec) = 0;
609 607
610 /* 608 /*
611 * Get generic FEC setting 609 * Get generic FEC setting
612 *
613 * return -1 on failure else 0
614 */ 610 */
615 virtual int32_t GenericFECStatus(bool& enable, 611 virtual void GenericFECStatus(bool& enable,
616 uint8_t& payloadTypeRED, 612 uint8_t& payloadTypeRED,
617 uint8_t& payloadTypeFEC) = 0; 613 uint8_t& payloadTypeFEC) = 0;
618 614
619 615
620 virtual int32_t SetFecParameters( 616 virtual int32_t SetFecParameters(
621 const FecProtectionParams* delta_params, 617 const FecProtectionParams* delta_params,
622 const FecProtectionParams* key_params) = 0; 618 const FecProtectionParams* key_params) = 0;
623 619
624 /* 620 /*
625 * Set method for requestion a new key frame 621 * Set method for requestion a new key frame
626 * 622 *
627 * return -1 on failure else 0 623 * return -1 on failure else 0
628 */ 624 */
629 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0; 625 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
630 626
631 /* 627 /*
632 * send a request for a keyframe 628 * send a request for a keyframe
633 * 629 *
634 * return -1 on failure else 0 630 * return -1 on failure else 0
635 */ 631 */
636 virtual int32_t RequestKeyFrame() = 0; 632 virtual int32_t RequestKeyFrame() = 0;
637 }; 633 };
638 } // namespace webrtc 634 } // namespace webrtc
639 #endif // WEBRTC_MODULES_RTP_RTCP_INTERFACE_RTP_RTCP_H_ 635 #endif // WEBRTC_MODULES_RTP_RTCP_INTERFACE_RTP_RTCP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698