Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Merge methods for configuring NACK/FEC/hybrid. BUG=webrtc:1695 R=stefan@webrtc.org

Patch Set 1 #

Patch Set 2 : Remove distinction between send and receive NACK. Allow disabling receive-side. #

Total comments: 4

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -226 lines) Patch
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 1 chunk +6 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +6 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 1 chunk +6 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/main/interface/video_coding_defines.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/media_opt_util.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/media_opt_util.cc View 5 chunks +12 lines, -22 lines 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization.cc View 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_coding_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/video_coding_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/video_receiver.cc View 1 3 chunks +11 lines, -24 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender.cc View 1 2 1 chunk +5 lines, -8 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 1 chunk +7 lines, -21 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 2 2 chunks +5 lines, -16 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 2 3 chunks +36 lines, -73 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
pbos-webrtc
PTAL, this refactoring also moves a bit towards removing the enable/disable flag in SetVideoProtection. I ...
5 years, 5 months ago (2015-07-10 12:49:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226143013/1
5 years, 5 months ago (2015-07-10 12:50:12 UTC) #3
pbos-webrtc
Remove distinction between send and receive NACK. Allow disabling receive-side.
5 years, 5 months ago (2015-07-10 13:09:52 UTC) #4
stefan-webrtc
My god... https://codereview.webrtc.org/1226143013/diff/20001/webrtc/modules/video_coding/main/source/media_opt_util.cc File webrtc/modules/video_coding/main/source/media_opt_util.cc (right): https://codereview.webrtc.org/1226143013/diff/20001/webrtc/modules/video_coding/main/source/media_opt_util.cc#newcode748 webrtc/modules/video_coding/main/source/media_opt_util.cc:748: return _selectedMethod ? _selectedMethod->Type() : kNone; Doesn't ...
5 years, 5 months ago (2015-07-14 12:29:12 UTC) #5
pbos-webrtc
https://codereview.webrtc.org/1226143013/diff/20001/webrtc/modules/video_coding/main/source/media_opt_util.cc File webrtc/modules/video_coding/main/source/media_opt_util.cc (right): https://codereview.webrtc.org/1226143013/diff/20001/webrtc/modules/video_coding/main/source/media_opt_util.cc#newcode748 webrtc/modules/video_coding/main/source/media_opt_util.cc:748: return _selectedMethod ? _selectedMethod->Type() : kNone; On 2015/07/14 12:29:12, ...
5 years, 5 months ago (2015-07-14 12:41:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226143013/20001
5 years, 5 months ago (2015-07-14 12:42:41 UTC) #8
stefan-webrtc
lgtm
5 years, 5 months ago (2015-07-14 12:58:41 UTC) #9
pbos-webrtc
rebase
5 years, 5 months ago (2015-07-14 14:23:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226143013/40001
5 years, 5 months ago (2015-07-14 14:25:57 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ba8c15b857c0f341d9c1e02d41b6ccd56f9f1030 Cr-Commit-Position: refs/heads/master@{#9580}
5 years, 5 months ago (2015-07-14 16:36:46 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 16:36:52 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698