webrtc/modules/video_coding/main/source/video_coding_impl.cc - Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/main/source/video_coding_impl.cc

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/main/source/video_coding_impl.cc

diff --git a/webrtc/modules/video_coding/main/source/video_coding_impl.cc b/webrtc/modules/video_coding/main/source/video_coding_impl.cc

index c207f00f0e64485868bb1a25def8bc4c60b68a83..e0cf4796231a070ec3e7ea0f1b96ce6e060bcc10 100644

--- a/webrtc/modules/video_coding/main/source/video_coding_impl.cc

+++ b/webrtc/modules/video_coding/main/source/video_coding_impl.cc

@@ -168,7 +168,9 @@ class VideoCodingModuleImpl : public VideoCodingModule {

int32_t SetVideoProtection(VCMVideoProtection videoProtection,

bool enable) override {

- sender_->SetVideoProtection(enable, videoProtection);

+ // TODO(pbos): Remove enable from receive-side protection modes as well.

+ if (enable)

+ sender_->SetVideoProtection(videoProtection);

return receiver_->SetVideoProtection(videoProtection, enable);

}