Split iSAC encoder/decoder: Test more cases (and make sure they work)

Split iSAC encoder/decoder: Test more cases (and make sure they work)

This patch tests separate iSAC encoder and decoder in more cases (32
kHz in addition to 16 kHz, and 30 ms adaptive and 60 ms nonadaptive).

In order to handle 32 kHz adaptive, the decoder needs to be told of
the encoder's sample rate (16 kHz worked already because that's the
default). And since we can't set the encoder's frame size without also
setting its bit rate, we need a way to set the decoder's bit rate as
well.

It turned out to be way too messy to continue verifying that the
bandwidth estimator does something reasonable in all these cases,
because it seems it doesn't. So the GetSetBandwidthInfo is now just
responsible for ensuring that split encoder/decoder behaves the same
as conjoined encoder/decoder; the job of verifying that the bandwidth
estimator does its job properly falls on some other test (that doesn't
exist yet).

Committed: https://crrev.com/3258db26ed7cedd20e1e21aca70d8304c7cef218
Cr-Commit-Position: refs/heads/master@{#9583}

[kwiberg-webrtc, 2015-07-09 19:40:39]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, jmarusic@webrtc.org

[kwiberg-webrtc, 2015-07-09 19:42:53]

Please review. This is a prequel to https://codereview.webrtc.org/1208993010/,
which grew out of my attempts to fix the remaining problems there (which
surfaced when using super wideband mode (32 kHz)).

[Jelena, 2015-07-10 05:18:46]

lgtm

https://codereview.webrtc.org/1225093005/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/isac/main/interface/isac.h (right):

https://codereview.webrtc.org/1225093005/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/isac/main/interface/isac.h:711: /* Fills in
an IsacBandwidthInfo struct. inst should be a decoder. */
maybe:
|inst| instead of inst. I have seen it used in comments to denote param name.

[kwiberg-webrtc, 2015-07-15 00:24:50]

Patch set #3 addresses the review comment.

https://codereview.webrtc.org/1225093005/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/isac/main/interface/isac.h (right):

https://codereview.webrtc.org/1225093005/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/isac/main/interface/isac.h:711: /* Fills in
an IsacBandwidthInfo struct. inst should be a decoder. */
On 2015/07/10 05:18:46, Jelena wrote:
> maybe:
> |inst| instead of inst. I have seen it used in comments to denote param name.

Done.

[kwiberg-webrtc, 2015-07-15 01:53:46]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-07-15 01:53:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jmarusic@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1225093005/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2015-07-15 01:53:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1225093005/60001

[commit-bot: I haz the power, 2015-07-15 01:54:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-15 01:54:51]

Patchset 4 (id:??) landed as
https://crrev.com/3258db26ed7cedd20e1e21aca70d8304c7cef218
Cr-Commit-Position: refs/heads/master@{#9583}