Chromium Code Reviews

Issue 1219663008: Remove media sinks from Channel. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove media sinks from Channel. Allows removing MediaRecorder which isn't in use apart from channel unittests, along with it unittests for MediaRecorder that are flaky when run in parallel can also go. BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/3b1e647b6a6f74d8e4392e012fe2262b3d2c4334 Cr-Commit-Position: refs/heads/master@{#9558}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -869 lines)
M talk/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments
M talk/libjingle_tests.gyp View 1 chunk +0 lines, -1 line 0 comments
M talk/session/media/channel.h View 2 chunks +0 lines, -73 lines 0 comments
M talk/session/media/channel.cc View 4 chunks +0 lines, -24 lines 0 comments
M talk/session/media/channel_unittest.cc View 4 chunks +0 lines, -70 lines 0 comments
D talk/session/media/mediarecorder.h View 1 chunk +0 lines, -119 lines 0 comments
D talk/session/media/mediarecorder.cc View 1 chunk +0 lines, -224 lines 0 comments
D talk/session/media/mediarecorder_unittest.cc View 1 chunk +0 lines, -356 lines 0 comments

Messages

Total messages: 19 (6 generated)
pbos-webrtc
Hey Peter, am I allowed to delete some code? :)
5 years, 5 months ago (2015-07-02 14:49:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219663008/1
5 years, 5 months ago (2015-07-02 14:49:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-02 16:36:39 UTC) #5
pthatcher1
lgtm
5 years, 5 months ago (2015-07-08 18:10:45 UTC) #6
pthatcher1
lgtm
5 years, 5 months ago (2015-07-08 18:10:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219663008/1
5 years, 5 months ago (2015-07-09 09:44:09 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-09 09:44:11 UTC) #11
tommi
Rs lgtm
5 years, 5 months ago (2015-07-09 09:57:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219663008/1
5 years, 5 months ago (2015-07-09 09:58:30 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 10:57:58 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b1e647b6a6f74d8e4392e012fe2262b3d2c4334 Cr-Commit-Position: refs/heads/master@{#9558}
5 years, 5 months ago (2015-07-09 10:58:07 UTC) #17
phoglund
On 2015/07/09 09:58:30, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 5 months ago (2015-07-09 10:58:37 UTC) #18
pbos-webrtc
5 years, 5 months ago (2015-07-09 12:07:56 UTC) #19
Message was sent while issue was closed. 
On 2015/07/09 10:58:37, phoglund wrote:
> On 2015/07/09 09:58:30, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1219663008/1
> 
> There was a typo in the committer list for pthatcher, so I'm fixing that with
> https://chromereviews.googleplex.com/226687013.

thx :)

Powered by Google App Engine