Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: talk/session/media/channel.h

Issue 1219663008: Remove media sinks from Channel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/libjingle_tests.gyp ('k') | talk/session/media/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/session/media/channel.h
diff --git a/talk/session/media/channel.h b/talk/session/media/channel.h
index 904777e1754a2db5d2fea525b7aca066fc713c11..bb2dffdc905dfd7024ab017f567a3283d284efdc 100644
--- a/talk/session/media/channel.h
+++ b/talk/session/media/channel.h
@@ -148,72 +148,6 @@ class BaseChannel
srtp_filter_.set_signal_silent_time(silent_time);
}
- template <class T>
- void RegisterSendSink(T* sink,
- void (T::*OnPacket)(const void*, size_t, bool),
- SinkType type) {
- rtc::CritScope cs(&signal_send_packet_cs_);
- if (SINK_POST_CRYPTO == type) {
- SignalSendPacketPostCrypto.disconnect(sink);
- SignalSendPacketPostCrypto.connect(sink, OnPacket);
- } else {
- SignalSendPacketPreCrypto.disconnect(sink);
- SignalSendPacketPreCrypto.connect(sink, OnPacket);
- }
- }
-
- void UnregisterSendSink(sigslot::has_slots<>* sink,
- SinkType type) {
- rtc::CritScope cs(&signal_send_packet_cs_);
- if (SINK_POST_CRYPTO == type) {
- SignalSendPacketPostCrypto.disconnect(sink);
- } else {
- SignalSendPacketPreCrypto.disconnect(sink);
- }
- }
-
- bool HasSendSinks(SinkType type) {
- rtc::CritScope cs(&signal_send_packet_cs_);
- if (SINK_POST_CRYPTO == type) {
- return !SignalSendPacketPostCrypto.is_empty();
- } else {
- return !SignalSendPacketPreCrypto.is_empty();
- }
- }
-
- template <class T>
- void RegisterRecvSink(T* sink,
- void (T::*OnPacket)(const void*, size_t, bool),
- SinkType type) {
- rtc::CritScope cs(&signal_recv_packet_cs_);
- if (SINK_POST_CRYPTO == type) {
- SignalRecvPacketPostCrypto.disconnect(sink);
- SignalRecvPacketPostCrypto.connect(sink, OnPacket);
- } else {
- SignalRecvPacketPreCrypto.disconnect(sink);
- SignalRecvPacketPreCrypto.connect(sink, OnPacket);
- }
- }
-
- void UnregisterRecvSink(sigslot::has_slots<>* sink,
- SinkType type) {
- rtc::CritScope cs(&signal_recv_packet_cs_);
- if (SINK_POST_CRYPTO == type) {
- SignalRecvPacketPostCrypto.disconnect(sink);
- } else {
- SignalRecvPacketPreCrypto.disconnect(sink);
- }
- }
-
- bool HasRecvSinks(SinkType type) {
- rtc::CritScope cs(&signal_recv_packet_cs_);
- if (SINK_POST_CRYPTO == type) {
- return !SignalRecvPacketPostCrypto.is_empty();
- } else {
- return !SignalRecvPacketPreCrypto.is_empty();
- }
- }
-
BundleFilter* bundle_filter() { return &bundle_filter_; }
const std::vector<StreamParams>& local_streams() const {
@@ -377,13 +311,6 @@ class BaseChannel
}
private:
- sigslot::signal3<const void*, size_t, bool> SignalSendPacketPreCrypto;
- sigslot::signal3<const void*, size_t, bool> SignalSendPacketPostCrypto;
- sigslot::signal3<const void*, size_t, bool> SignalRecvPacketPreCrypto;
- sigslot::signal3<const void*, size_t, bool> SignalRecvPacketPostCrypto;
- rtc::CriticalSection signal_send_packet_cs_;
- rtc::CriticalSection signal_recv_packet_cs_;
-
rtc::Thread* worker_thread_;
MediaEngineInterface* media_engine_;
BaseSession* session_;
« no previous file with comments | « talk/libjingle_tests.gyp ('k') | talk/session/media/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698