Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1219333003: Targets should not depend on protobuf when enable_protobuf=0. (Closed)

Created:
5 years, 5 months ago by andresp
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Only include if needed. #

Patch Set 3 : Do not define AcmDump::ParseAcmDump #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_dump.cc View 1 2 3 chunks +8 lines, -7 lines 1 comment Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi View 2 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
stefan-webrtc
lgtm
5 years, 5 months ago (2015-07-03 13:39:09 UTC) #2
andresp
5 years, 5 months ago (2015-07-03 13:40:20 UTC) #3
andresp
5 years, 5 months ago (2015-07-03 13:40:23 UTC) #4
hlundin-webrtc
lgtm with a nit (or maybe a note to ivoc@ and terelius@ going forward). https://codereview.webrtc.org/1219333003/diff/40001/webrtc/modules/audio_coding/main/acm2/acm_dump.cc ...
5 years, 5 months ago (2015-07-03 15:13:26 UTC) #5
andresp
5 years, 5 months ago (2015-07-03 15:53:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
72a8cee42587f8512d69102e5cc346415ab71c26.

Powered by Google App Engine
This is Rietveld 408576698