Targets should not depend on protobuf when enable_protobuf=0.

webrtc/modules/audio_coding/main/acm2/acm_dump.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/audio_coding/main/acm2/acm_dump.h"
 
 #include <deque>
 
 #include "webrtc/base/checks.h"
 #include "webrtc/base/thread_annotations.h"
 #include "webrtc/system_wrappers/interface/clock.h"
 #include "webrtc/system_wrappers/interface/critical_section_wrapper.h"
 #include "webrtc/system_wrappers/interface/file_wrapper.h"
 
+#ifdef RTC_AUDIOCODING_DEBUG_DUMP
 // Files generated at build-time by the protobuf compiler.
 #ifdef WEBRTC_ANDROID_PLATFORM_BUILD
 #include "external/webrtc/webrtc/modules/audio_coding/dump.pb.h"
 #else
 #include "webrtc/audio_coding/dump.pb.h"
 #endif
+#endif
 
 namespace webrtc {
 
 // Noop implementation if flag is not set
 #ifndef RTC_AUDIOCODING_DEBUG_DUMP
 class AcmDumpImpl final : public AcmDump {
  public:
   void StartLogging(const std::string& file_name, int duration_ms) override{};
   void LogRtpPacket(bool incoming,
                     const uint8_t* packet,
@@ skipping 169 matching lines @@
 }
 
 void AcmDumpImpl::AddRecentEvent(const ACMDumpEvent& event) {
   recent_log_events_.push_back(event);
   while (recent_log_events_.front().timestamp_us() <
          event.timestamp_us() - recent_log_duration_us) {
     recent_log_events_.pop_front();
   }
 }
 
-#endif  // RTC_AUDIOCODING_DEBUG_DUMP
-
-// AcmDump member functions.
-rtc::scoped_ptr<AcmDump> AcmDump::Create() {
-  return rtc::scoped_ptr<AcmDump>(new AcmDumpImpl());
-}
-
 bool AcmDump::ParseAcmDump(const std::string& file_name,

[hlundin-webrtc, 2015/07/03 15:13:26]

AcmDump::ParseAcmDump() no longer has an implementation when
RTC_AUDIOCODING_DEBUG_DUMP is 0. I guess this is fine for now, since the
function is never called unless the precompiler define is set, but it might be
good to fix this going forward.

                            ACMDumpEventStream* result) {
   char tmp_buffer[1024];
   int bytes_read = 0;
   rtc::scoped_ptr<FileWrapper> dump_file(FileWrapper::Create());
   if (dump_file->OpenFile(file_name.c_str(), true) != 0) {
     return false;
   }
   std::string dump_buffer;
   while ((bytes_read = dump_file->Read(tmp_buffer, sizeof(tmp_buffer))) > 0) {
     dump_buffer.append(tmp_buffer, bytes_read);
   }
   dump_file->CloseFile();
   return result->ParseFromString(dump_buffer);
 }
 
+#endif  // RTC_AUDIOCODING_DEBUG_DUMP
+
+// AcmDump member functions.
+rtc::scoped_ptr<AcmDump> AcmDump::Create() {
+  return rtc::scoped_ptr<AcmDump>(new AcmDumpImpl());
+}
 }  // namespace webrtc