Fix issue where the first audio packets significantly impacts initial BWE negatively.

Wait for a longer time (5 seconds) before establishing the first bandwidth estimate.

This reduces the risk of getting a small initial estimate when doing combined a/v BWE, and the audio stream is received earlier than the video stream.

In addition a check is added to make sure a probe can't reduce the BWE.

R=pbos@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/11324b95612876e3335b20c4188bc9790d0b8539

[stefan-webrtc, 2015-07-02 16:46:02]

stefan@webrtc.org changed reviewers:
+ pbos@webrtc.org

[stefan-webrtc, 2015-07-09 12:04:03]

PTAL

[pbos-webrtc, 2015-07-09 15:14:55]

lgtm

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc (right):

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:106:
std::max<int64_t>(kBitrateWindowMs, 5000);
Just compile assert that kBitrateWindowMs < kInitializationTimeMs.

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:141: if
(!bitrate_is_initialized_ && current_input_._bwState != kBwOverusing) {
remove {}s

comment that we pass this if we're overusing and that that makes us initialize
bitrate. (Or comment what's going on here.)

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:192:
probe_bitrate_bps > static_cast<int>(incoming_bitrate_.Rate(now_ms))) {
Explain why it's needed.

[pbos-webrtc, 2015-07-09 15:15:09]

On 2015/07/09 15:14:55, pbos-webrtc wrote:
> lgtm
> 
>
https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
> File webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc (right):
> 
>
https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
> webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:106:
> std::max<int64_t>(kBitrateWindowMs, 5000);
> Just compile assert that kBitrateWindowMs < kInitializationTimeMs.
> 
>
https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
> webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:141: if
> (!bitrate_is_initialized_ && current_input_._bwState != kBwOverusing) {
> remove {}s
> 
> comment that we pass this if we're overusing and that that makes us initialize
> bitrate. (Or comment what's going on here.)
> 
>
https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
> File
>
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
> (right):
> 
>
https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
>
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:192:
> probe_bitrate_bps > static_cast<int>(incoming_bitrate_.Rate(now_ms))) {
> Explain why it's needed.

make the cl description cooler (you know what I mean)

[stefan-webrtc, 2015-07-09 15:24:27]

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc (right):

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc:106:
std::max<int64_t>(kBitrateWindowMs, 5000);
On 2015/07/09 15:14:55, pbos-webrtc wrote:
> Just compile assert that kBitrateWindowMs < kInitializationTimeMs.

Done.

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.webrtc.org/1219303002/diff/80001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:192:
probe_bitrate_bps > static_cast<int>(incoming_bitrate_.Rate(now_ms))) {
On 2015/07/09 15:14:55, pbos-webrtc wrote:
> Explain why it's needed.

Done.

[stefan-webrtc, 2015-07-09 15:28:13]

Committed patchset #6 (id:100001) manually as
11324b95612876e3335b20c4188bc9790d0b8539 (presubmit successful).