webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc - Issue 1219303002: Fix issue where the first audio packets significantly impacts initial BWE negatively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

Issue 1219303002: Fix issue where the first audio packets significantly impacts initial BWE negatively. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Comments addressed. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

index bca8ba6ed61a0e99f702b9165c1ec48b2dafa169..762a3170ae1eccb3eccde91a29772b0718628fd9 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

@@ -47,7 +47,7 @@ struct RemoteBitrateEstimatorSingleStream::Detector {

Clock* clock,

uint32_t min_bitrate_bps)

: clock_(clock),

- incoming_bitrate_(1000, 8000),

+ incoming_bitrate_(kBitrateWindowMs, 8000),

remote_rate_(new AimdRateControl(min_bitrate_bps)),

observer_(observer),

crit_sect_(CriticalSectionWrapper::CreateCriticalSection()),