Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1215603003: Remove VCM_*_PAYLOAD_TYPE constants. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VCM_*_PAYLOAD_TYPE constants. These payload types aren't directly connected to any payload type, and the payload type still has to be negotiated externally. As such these constants are just a source of confusion. BUG= R=stefan@webrtc.org Committed: https://crrev.com/a7d70546ad40f535b76b1ef57afc28bcba8ce09f Cr-Commit-Position: refs/heads/master@{#9546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M webrtc/modules/video_coding/main/interface/video_coding_defines.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/main/test/video_rtp_play.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
pbos-webrtc
PTAL
5 years, 5 months ago (2015-07-07 13:03:59 UTC) #1
stefan-webrtc
lgtm
5 years, 5 months ago (2015-07-07 13:04:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215603003/1
5 years, 5 months ago (2015-07-07 13:05:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/8411) (exceeded global retry quota)
5 years, 5 months ago (2015-07-07 13:06:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215603003/1
5 years, 5 months ago (2015-07-07 13:17:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/8210) (exceeded global retry quota)
5 years, 5 months ago (2015-07-07 13:18:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215603003/1
5 years, 5 months ago (2015-07-07 13:29:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/5453) win_x64_rel on tryserver.webrtc (JOB_FAILED, ...
5 years, 5 months ago (2015-07-07 13:31:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215603003/1
5 years, 5 months ago (2015-07-07 13:57:36 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 14:35:53 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 14:36:06 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7d70546ad40f535b76b1ef57afc28bcba8ce09f
Cr-Commit-Position: refs/heads/master@{#9546}

Powered by Google App Engine
This is Rietveld 408576698