Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: webrtc/modules/video_coding/main/source/codec_database.cc

Issue 1215603003: Remove VCM_*_PAYLOAD_TYPE constants. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 13 matching lines...) Expand all
24 #include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h" 24 #include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
25 #endif 25 #endif
26 #ifdef VIDEOCODEC_VP9 26 #ifdef VIDEOCODEC_VP9
27 #include "webrtc/modules/video_coding/codecs/vp9/include/vp9.h" 27 #include "webrtc/modules/video_coding/codecs/vp9/include/vp9.h"
28 #endif 28 #endif
29 #include "webrtc/modules/video_coding/main/source/internal_defines.h" 29 #include "webrtc/modules/video_coding/main/source/internal_defines.h"
30 #include "webrtc/system_wrappers/interface/logging.h" 30 #include "webrtc/system_wrappers/interface/logging.h"
31 31
32 namespace { 32 namespace {
33 const size_t kDefaultPayloadSize = 1440; 33 const size_t kDefaultPayloadSize = 1440;
34 const uint8_t kDefaultPayloadType = 100;
34 } 35 }
35 36
36 namespace webrtc { 37 namespace webrtc {
37 38
38 VideoCodecVP8 VideoEncoder::GetDefaultVp8Settings() { 39 VideoCodecVP8 VideoEncoder::GetDefaultVp8Settings() {
39 VideoCodecVP8 vp8_settings; 40 VideoCodecVP8 vp8_settings;
40 memset(&vp8_settings, 0, sizeof(vp8_settings)); 41 memset(&vp8_settings, 0, sizeof(vp8_settings));
41 42
42 vp8_settings.resilience = kResilientStream; 43 vp8_settings.resilience = kResilientStream;
43 vp8_settings.numberOfTemporalLayers = 1; 44 vp8_settings.numberOfTemporalLayers = 1;
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 if (list_id >= VCM_NUM_VIDEO_CODECS_AVAILABLE) { 134 if (list_id >= VCM_NUM_VIDEO_CODECS_AVAILABLE) {
134 return false; 135 return false;
135 } 136 }
136 memset(settings, 0, sizeof(VideoCodec)); 137 memset(settings, 0, sizeof(VideoCodec));
137 switch (list_id) { 138 switch (list_id) {
138 #ifdef VIDEOCODEC_VP8 139 #ifdef VIDEOCODEC_VP8
139 case VCM_VP8_IDX: { 140 case VCM_VP8_IDX: {
140 strncpy(settings->plName, "VP8", 4); 141 strncpy(settings->plName, "VP8", 4);
141 settings->codecType = kVideoCodecVP8; 142 settings->codecType = kVideoCodecVP8;
142 // 96 to 127 dynamic payload types for video codecs. 143 // 96 to 127 dynamic payload types for video codecs.
143 settings->plType = VCM_VP8_PAYLOAD_TYPE; 144 settings->plType = kDefaultPayloadType;
144 settings->startBitrate = kDefaultStartBitrateKbps; 145 settings->startBitrate = kDefaultStartBitrateKbps;
145 settings->minBitrate = VCM_MIN_BITRATE; 146 settings->minBitrate = VCM_MIN_BITRATE;
146 settings->maxBitrate = 0; 147 settings->maxBitrate = 0;
147 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE; 148 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE;
148 settings->width = VCM_DEFAULT_CODEC_WIDTH; 149 settings->width = VCM_DEFAULT_CODEC_WIDTH;
149 settings->height = VCM_DEFAULT_CODEC_HEIGHT; 150 settings->height = VCM_DEFAULT_CODEC_HEIGHT;
150 settings->numberOfSimulcastStreams = 0; 151 settings->numberOfSimulcastStreams = 0;
151 settings->qpMax = 56; 152 settings->qpMax = 56;
152 settings->codecSpecific.VP8 = VideoEncoder::GetDefaultVp8Settings(); 153 settings->codecSpecific.VP8 = VideoEncoder::GetDefaultVp8Settings();
153 return true; 154 return true;
154 } 155 }
155 #endif 156 #endif
156 #ifdef VIDEOCODEC_VP9 157 #ifdef VIDEOCODEC_VP9
157 case VCM_VP9_IDX: { 158 case VCM_VP9_IDX: {
158 strncpy(settings->plName, "VP9", 4); 159 strncpy(settings->plName, "VP9", 4);
159 settings->codecType = kVideoCodecVP9; 160 settings->codecType = kVideoCodecVP9;
160 // 96 to 127 dynamic payload types for video codecs. 161 // 96 to 127 dynamic payload types for video codecs.
161 settings->plType = VCM_VP9_PAYLOAD_TYPE; 162 settings->plType = kDefaultPayloadType;
162 settings->startBitrate = 100; 163 settings->startBitrate = 100;
163 settings->minBitrate = VCM_MIN_BITRATE; 164 settings->minBitrate = VCM_MIN_BITRATE;
164 settings->maxBitrate = 0; 165 settings->maxBitrate = 0;
165 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE; 166 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE;
166 settings->width = VCM_DEFAULT_CODEC_WIDTH; 167 settings->width = VCM_DEFAULT_CODEC_WIDTH;
167 settings->height = VCM_DEFAULT_CODEC_HEIGHT; 168 settings->height = VCM_DEFAULT_CODEC_HEIGHT;
168 settings->numberOfSimulcastStreams = 0; 169 settings->numberOfSimulcastStreams = 0;
169 settings->qpMax = 56; 170 settings->qpMax = 56;
170 settings->codecSpecific.VP9 = VideoEncoder::GetDefaultVp9Settings(); 171 settings->codecSpecific.VP9 = VideoEncoder::GetDefaultVp9Settings();
171 return true; 172 return true;
172 } 173 }
173 #endif 174 #endif
174 #ifdef VIDEOCODEC_H264 175 #ifdef VIDEOCODEC_H264
175 case VCM_H264_IDX: { 176 case VCM_H264_IDX: {
176 strncpy(settings->plName, "H264", 5); 177 strncpy(settings->plName, "H264", 5);
177 settings->codecType = kVideoCodecH264; 178 settings->codecType = kVideoCodecH264;
178 // 96 to 127 dynamic payload types for video codecs. 179 // 96 to 127 dynamic payload types for video codecs.
179 settings->plType = VCM_H264_PAYLOAD_TYPE; 180 settings->plType = kDefaultPayloadType;
180 settings->startBitrate = kDefaultStartBitrateKbps; 181 settings->startBitrate = kDefaultStartBitrateKbps;
181 settings->minBitrate = VCM_MIN_BITRATE; 182 settings->minBitrate = VCM_MIN_BITRATE;
182 settings->maxBitrate = 0; 183 settings->maxBitrate = 0;
183 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE; 184 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE;
184 settings->width = VCM_DEFAULT_CODEC_WIDTH; 185 settings->width = VCM_DEFAULT_CODEC_WIDTH;
185 settings->height = VCM_DEFAULT_CODEC_HEIGHT; 186 settings->height = VCM_DEFAULT_CODEC_HEIGHT;
186 settings->numberOfSimulcastStreams = 0; 187 settings->numberOfSimulcastStreams = 0;
187 settings->qpMax = 56; 188 settings->qpMax = 56;
188 settings->codecSpecific.H264 = VideoEncoder::GetDefaultH264Settings(); 189 settings->codecSpecific.H264 = VideoEncoder::GetDefaultH264Settings();
189 return true; 190 return true;
190 } 191 }
191 #endif 192 #endif
192 #ifdef VIDEOCODEC_I420 193 #ifdef VIDEOCODEC_I420
193 case VCM_I420_IDX: { 194 case VCM_I420_IDX: {
194 strncpy(settings->plName, "I420", 5); 195 strncpy(settings->plName, "I420", 5);
195 settings->codecType = kVideoCodecI420; 196 settings->codecType = kVideoCodecI420;
196 // 96 to 127 dynamic payload types for video codecs. 197 // 96 to 127 dynamic payload types for video codecs.
197 settings->plType = VCM_I420_PAYLOAD_TYPE; 198 settings->plType = kDefaultPayloadType;
198 // Bitrate needed for this size and framerate. 199 // Bitrate needed for this size and framerate.
199 settings->startBitrate = 3 * VCM_DEFAULT_CODEC_WIDTH * 200 settings->startBitrate = 3 * VCM_DEFAULT_CODEC_WIDTH *
200 VCM_DEFAULT_CODEC_HEIGHT * 8 * 201 VCM_DEFAULT_CODEC_HEIGHT * 8 *
201 VCM_DEFAULT_FRAME_RATE / 1000 / 2; 202 VCM_DEFAULT_FRAME_RATE / 1000 / 2;
202 settings->maxBitrate = settings->startBitrate; 203 settings->maxBitrate = settings->startBitrate;
203 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE; 204 settings->maxFramerate = VCM_DEFAULT_FRAME_RATE;
204 settings->width = VCM_DEFAULT_CODEC_WIDTH; 205 settings->width = VCM_DEFAULT_CODEC_WIDTH;
205 settings->height = VCM_DEFAULT_CODEC_HEIGHT; 206 settings->height = VCM_DEFAULT_CODEC_HEIGHT;
206 settings->minBitrate = VCM_MIN_BITRATE; 207 settings->minBitrate = VCM_MIN_BITRATE;
207 settings->numberOfSimulcastStreams = 0; 208 settings->numberOfSimulcastStreams = 0;
(...skipping 521 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 730
730 const VCMExtDecoderMapItem* VCMCodecDataBase::FindExternalDecoderItem( 731 const VCMExtDecoderMapItem* VCMCodecDataBase::FindExternalDecoderItem(
731 uint8_t payload_type) const { 732 uint8_t payload_type) const {
732 ExternalDecoderMap::const_iterator it = dec_external_map_.find(payload_type); 733 ExternalDecoderMap::const_iterator it = dec_external_map_.find(payload_type);
733 if (it != dec_external_map_.end()) { 734 if (it != dec_external_map_.end()) {
734 return (*it).second; 735 return (*it).second;
735 } 736 }
736 return NULL; 737 return NULL;
737 } 738 }
738 } // namespace webrtc 739 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698