Remove ResetStatistics from RTP feedback.

Remove ResetStatistics from RTP feedback.

BUG=
R=asapersson@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/d436298332c7a7ecb51241f3a66588539c2ece83
Cr-Commit-Position: refs/heads/master@{#9548}

[pbos-webrtc, 2015-06-25 20:07:31]

PTAL, specifically w/r/t/ if this is actually legal. For the purpose of GetStats
I don't think it makes sense to reset SSRC stats because a new payload type
arrives, but I'm not sure if this causes incorrect receiver reports or
something.

[pbos-webrtc, 2015-06-26 13:04:22]

Remove more data counter resetting.

[stefan-webrtc, 2015-06-26 13:46:48]

Calling StopSend() and StartSend() should result in a new SSRC, which should
result in fresh statistics. We have to handle that in some way. Otherwise I'm ok
with this.

[pbos-webrtc, 2015-06-26 13:47:52]

On 2015/06/26 13:46:48, stefan-webrtc (holmer) wrote:
> Calling StopSend() and StartSend() should result in a new SSRC, which should
> result in fresh statistics. We have to handle that in some way. Otherwise I'm
ok
> with this.

It should not, and doesn't when SSRCs are set, which they always are from talk/.

[stefan-webrtc, 2015-07-01 13:24:21]

lgtm

[stefan-webrtc, 2015-07-01 13:25:18]

Or maybe good to get magnus input on this, as I may be missing something...

[stefan-webrtc, 2015-07-01 13:26:52]

stefan@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[stefan-webrtc, 2015-07-01 13:26:53]

Magnus, can you see a reason why StopSend()/StartSend() has to reset statistics
now that we use the new API? Should be fine not to do that, right?

[mflodman, 2015-07-03 13:12:56]

mflodman@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[mflodman, 2015-07-03 13:13:05]

On 2015/07/01 13:26:53, stefan-webrtc (holmer) wrote:
> Magnus, can you see a reason why StopSend()/StartSend() has to reset
statistics
> now that we use the new API? Should be fine not to do that, right?

Looping in Åsa, who wrote this and has the backstory.

I don't know exactly when Stop() is called, e.g. it's used in
WebRtcVideoChannel2::SetSend. If a stream is stopped for a while, this CL will
change the bitrate stats. I don't know how much of an issue that really is?

[åsapersson, 2015-07-07 12:18:43]

See comment. Otherwise I am ok with the change, lgtm.

https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_c...
File webrtc/video_engine/vie_channel.cc (right):

https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_c...
webrtc/video_engine/vie_channel.cc:248: StreamDataCounters rtp;
move this outside if-statement above

[pbos-webrtc, 2015-07-07 13:24:12]

comment + rebase

[pbos-webrtc, 2015-07-07 13:31:26]

https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_c...
File webrtc/video_engine/vie_channel.cc (right):

https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_c...
webrtc/video_engine/vie_channel.cc:248: StreamDataCounters rtp;
On 2015/07/07 12:18:43, asapersson wrote:
> move this outside if-statement above

Done.

[pbos-webrtc, 2015-07-07 14:06:33]

On 2015/07/07 13:31:26, pbos-webrtc wrote:
>
https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_c...
> File webrtc/video_engine/vie_channel.cc (right):
> 
>
https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_c...
> webrtc/video_engine/vie_channel.cc:248: StreamDataCounters rtp;
> On 2015/07/07 12:18:43, asapersson wrote:
> > move this outside if-statement above
> 
> Done.

CQ:ing since mflodman@ is OOO.

[pbos-webrtc, 2015-07-07 14:06:40]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2015-07-07 14:06:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1213603002/#ps40001 (title:
"comment + rebase")

[commit-bot: I haz the power, 2015-07-07 14:06:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1213603002/40001

[commit-bot: I haz the power, 2015-07-07 14:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 14:08:47]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/116)

[henrika_webrtc, 2015-07-07 14:09:11]

voice_engine: LGTM

[pbos-webrtc, 2015-07-07 14:10:13]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-07-07 14:10:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1213603002/40001

[commit-bot: I haz the power, 2015-07-07 15:32:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-07 15:33:06]

Patchset 3 (id:??) landed as
https://crrev.com/d436298332c7a7ecb51241f3a66588539c2ece83
Cr-Commit-Position: refs/heads/master@{#9548}