Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1213603002: Remove ResetStatistics from RTP feedback. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, hlundin-webrtc, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ResetStatistics from RTP feedback. BUG= R=asapersson@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/d436298332c7a7ecb51241f3a66588539c2ece83 Cr-Commit-Position: refs/heads/master@{#9548}

Patch Set 1 #

Patch Set 2 : Remove more data counter resetting. #

Total comments: 2

Patch Set 3 : comment + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -186 lines) Patch
M webrtc/modules/rtp_rtcp/interface/receive_statistics.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 6 chunks +7 lines, -23 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 2 6 chunks +46 lines, -59 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 1 3 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 24 (6 generated)
pbos-webrtc
PTAL, specifically w/r/t/ if this is actually legal. For the purpose of GetStats I don't ...
5 years, 6 months ago (2015-06-25 20:07:31 UTC) #1
pbos-webrtc
Remove more data counter resetting.
5 years, 6 months ago (2015-06-26 13:04:22 UTC) #2
stefan-webrtc
Calling StopSend() and StartSend() should result in a new SSRC, which should result in fresh ...
5 years, 6 months ago (2015-06-26 13:46:48 UTC) #3
pbos-webrtc
On 2015/06/26 13:46:48, stefan-webrtc (holmer) wrote: > Calling StopSend() and StartSend() should result in a ...
5 years, 6 months ago (2015-06-26 13:47:52 UTC) #4
stefan-webrtc
lgtm
5 years, 5 months ago (2015-07-01 13:24:21 UTC) #5
stefan-webrtc
Or maybe good to get magnus input on this, as I may be missing something...
5 years, 5 months ago (2015-07-01 13:25:18 UTC) #6
stefan-webrtc
Magnus, can you see a reason why StopSend()/StartSend() has to reset statistics now that we ...
5 years, 5 months ago (2015-07-01 13:26:53 UTC) #8
mflodman
On 2015/07/01 13:26:53, stefan-webrtc (holmer) wrote: > Magnus, can you see a reason why StopSend()/StartSend() ...
5 years, 5 months ago (2015-07-03 13:13:05 UTC) #10
åsapersson
See comment. Otherwise I am ok with the change, lgtm. https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_channel.cc#newcode248 ...
5 years, 5 months ago (2015-07-07 12:18:43 UTC) #11
pbos-webrtc
comment + rebase
5 years, 5 months ago (2015-07-07 13:24:12 UTC) #12
pbos-webrtc
https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_channel.cc#newcode248 webrtc/video_engine/vie_channel.cc:248: StreamDataCounters rtp; On 2015/07/07 12:18:43, asapersson wrote: > move ...
5 years, 5 months ago (2015-07-07 13:31:26 UTC) #13
pbos-webrtc
On 2015/07/07 13:31:26, pbos-webrtc wrote: > https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_channel.cc > File webrtc/video_engine/vie_channel.cc (right): > > https://codereview.webrtc.org/1213603002/diff/20001/webrtc/video_engine/vie_channel.cc#newcode248 > ...
5 years, 5 months ago (2015-07-07 14:06:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213603002/40001
5 years, 5 months ago (2015-07-07 14:06:49 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/116)
5 years, 5 months ago (2015-07-07 14:08:47 UTC) #19
henrika_webrtc
voice_engine: LGTM
5 years, 5 months ago (2015-07-07 14:09:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213603002/40001
5 years, 5 months ago (2015-07-07 14:10:22 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-07 15:32:52 UTC) #23
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 15:33:06 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d436298332c7a7ecb51241f3a66588539c2ece83
Cr-Commit-Position: refs/heads/master@{#9548}

Powered by Google App Engine
This is Rietveld 408576698