webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc - Issue 1213603002: Remove ResetStatistics from RTP feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc

Issue 1213603002: Remove ResetStatistics from RTP feedback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: comment + rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc b/webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc

index 8b25bcf61508f928494f3bfcc486461fa75f22d0..fe9f71444e4e292393d74e53f953e9560bd476c2 100644

--- a/webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc

@@ -143,12 +143,6 @@ TEST_F(ReceiveStatisticsTest, GetReceiveStreamDataCounters) {

EXPECT_GT(counters.first_packet_time_ms, -1);

EXPECT_EQ(1u, counters.transmitted.packets);

- statistician->ResetStatistics();

- // GetReceiveStreamDataCounters includes reset counter values.

- statistician->GetReceiveStreamDataCounters(&counters);

- EXPECT_GT(counters.first_packet_time_ms, -1);

- EXPECT_EQ(1u, counters.transmitted.packets);

receive_statistics_->IncomingPacket(header1_, kPacketSize1, false);

statistician->GetReceiveStreamDataCounters(&counters);

EXPECT_GT(counters.first_packet_time_ms, -1);