Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: webrtc/modules/audio_processing/beamformer/beamformer.h

Issue 1211613005: Adding method IsInBeam to beamformer class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: cast M_PI as float to solve truncation bug Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/beamformer/beamformer.h
diff --git a/webrtc/modules/audio_processing/beamformer/beamformer.h b/webrtc/modules/audio_processing/beamformer/beamformer.h
index 04cb659c6d346954e23feef5af5613cbfa4af5e3..f31955448c0f59e25785b125881e0229df134e4c 100644
--- a/webrtc/modules/audio_processing/beamformer/beamformer.h
+++ b/webrtc/modules/audio_processing/beamformer/beamformer.h
@@ -31,6 +31,9 @@ class Beamformer {
// Needs to be called before the the Beamformer can be used.
virtual void Initialize(int chunk_size_ms, int sample_rate_hz) = 0;
+ // Indicates whether a given azimuth is inside of the beam.
+ virtual bool IsInBeam(SphericalPointf spherical_point) { return true; }
Andrew MacDonald 2015/06/26 02:04:24 Do we want to make this pure virtual after we upda
bloch 2015/06/26 03:37:28 I'm not sure. I like the logic of assuming "true"
Andrew MacDonald 2015/06/26 03:46:09 I'd argue the creator of such a beamformer _should
+
// Returns true if the current data contains the target signal.
// Which signals are considered "targets" is implementation dependent.
virtual bool is_target_present() = 0;

Powered by Google App Engine
This is Rietveld 408576698