Issue 1208313003: audio_processing: Changed kMinDiffDelayMs from 50 to 60 ms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1208313003: audio_processing: Changed kMinDiffDelayMs from 50 to 60 ms (Closed)

Created:
5 years, 5 months ago by bjornv1

Modified:
5 years, 5 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, aluebs-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

audio_processing: Changed kMinDiffDelayMs from 50 to 60 ms The UMA histograms WebRTC.Audio.AecSystemDelayJump and WebRTC.Audio.PlatformReportedStreamDelayJump triggers if the jump is larger than kMinDiffDelayMs. Especially WebRTC.Audio.AecSystemDelayJump is sensitive around 50 ms differences, since the granularity is 4 ms and we can get a significant amount of hits at 52 ms. Therefore, a change to 60 ms can make the logging more robust. The effect of not logging jumps in the interval 50-60 ms is of minor importance since they are not likely to affect the AEC performance. It's when we get values from ~100 ms and above that we should be worried. Tested with a local ToT Chromium build where 52, 64 and 200 ms jumps were forced. BUG=488124 TBR=henrik.lundin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d92f2674d7e99ae69b26d434b47ea0adf14aff0c

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	webrtc/modules/audio_processing/audio_processing_impl.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

bjornv1

5 years, 5 months ago (2015-07-05 08:46:17 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d92f2674d7e99ae69b26d434b47ea0adf14aff0c (presubmit successful).

Expand Messages | Collapse Messages