Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1208313003: audio_processing: Changed kMinDiffDelayMs from 50 to 60 ms (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index bf5b5eb9edea440158f4c7b7132f215778c271e8..fd6b2581413138bd5080f874be9df0cf35e6fb1c 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -1000,7 +1000,7 @@ void AudioProcessingImpl::InitializeBeamformer() {
}
void AudioProcessingImpl::MaybeUpdateHistograms() {
- static const int kMinDiffDelayMs = 50;
+ static const int kMinDiffDelayMs = 60;
if (echo_cancellation()->is_enabled()) {
// Detect a jump in platform reported system delay and log the difference.
@@ -1024,6 +1024,8 @@ void AudioProcessingImpl::MaybeUpdateHistograms() {
100);
}
last_aec_system_delay_ms_ = aec_system_delay_ms;
+ // TODO(bjornv): Consider also logging amount of jumps. This gives a better
+ // indication of how frequent jumps are.
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698