webrtc/modules/audio_coding/main/acm2/codec_owner.cc - Issue 1203803004: Adding a new ChangeLogger class to handle UMA logging of bitrates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/codec_owner.cc

Issue 1203803004: Adding a new ChangeLogger class to handle UMA logging of bitrates (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixing a typo Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/codec_manager.cc ('k') | webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/codec_owner.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/codec_owner.cc b/webrtc/modules/audio_coding/main/acm2/codec_owner.cc

index 5c1e37b5b0c2f493c067067369ab0c2a60038618..4d214be24281e313700fa43aca2efd2b20afa8e5 100644

--- a/webrtc/modules/audio_coding/main/acm2/codec_owner.cc

+++ b/webrtc/modules/audio_coding/main/acm2/codec_owner.cc

@@ -21,8 +21,6 @@

#include "webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h"

#include "webrtc/modules/audio_coding/codecs/pcm16b/include/audio_encoder_pcm16b.h"

#include "webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h"

-#include "webrtc/modules/audio_coding/main/acm2/acm_common_defs.h"

-#include "webrtc/system_wrappers/interface/metrics.h"

namespace webrtc {

namespace acm2 {

@@ -182,8 +180,6 @@ void CodecOwner::SetEncoders(const CodecInst& speech_inst,

&isac_is_encoder_);

external_speech_encoder_ = nullptr;

ChangeCngAndRed(cng_payload_type, vad_mode, red_payload_type);

- RTC_HISTOGRAM_COUNTS_100(HISTOGRAM_NAME_AUDIO_TARGET_BITRATE_IN_KBPS,

- SpeechEncoder()->GetTargetBitrate() / 1000);

}

void CodecOwner::SetEncoders(AudioEncoderMutable* external_speech_encoder,

@@ -194,8 +190,6 @@ void CodecOwner::SetEncoders(AudioEncoderMutable* external_speech_encoder,

speech_encoder_.reset();

isac_is_encoder_ = false;

ChangeCngAndRed(cng_payload_type, vad_mode, red_payload_type);

- RTC_HISTOGRAM_COUNTS_100(HISTOGRAM_NAME_AUDIO_TARGET_BITRATE_IN_KBPS,

- SpeechEncoder()->GetTargetBitrate() / 1000);

}

void CodecOwner::ChangeCngAndRed(int cng_payload_type,