webrtc/modules/audio_coding/main/acm2/codec_manager.cc - Issue 1203803004: Adding a new ChangeLogger class to handle UMA logging of bitrates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/codec_manager.cc

Issue 1203803004: Adding a new ChangeLogger class to handle UMA logging of bitrates (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixing a typo Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc ('k') | webrtc/modules/audio_coding/main/acm2/codec_owner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/codec_manager.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/codec_manager.cc b/webrtc/modules/audio_coding/main/acm2/codec_manager.cc

index d28dcc6ff5e6d63a2fbba52a7873c4869fce93cf..cad6ee908939b9c1523924f5b2d1b372b7077f1d 100644

--- a/webrtc/modules/audio_coding/main/acm2/codec_manager.cc

+++ b/webrtc/modules/audio_coding/main/acm2/codec_manager.cc

@@ -13,8 +13,6 @@

#include "webrtc/base/checks.h"

#include "webrtc/engine_configurations.h"

#include "webrtc/modules/audio_coding/main/acm2/acm_codec_database.h"

-#include "webrtc/modules/audio_coding/main/acm2/acm_common_defs.h"

-#include "webrtc/system_wrappers/interface/metrics.h"

#include "webrtc/system_wrappers/interface/trace.h"

namespace webrtc {

@@ -314,9 +312,6 @@ int CodecManager::RegisterEncoder(const CodecInst& send_codec) {

// Check if a change in Rate is required.

if (send_codec.rate != send_codec_inst_.rate) {

codec_owner_.SpeechEncoder()->SetTargetBitrate(send_codec.rate);

- RTC_HISTOGRAM_COUNTS_100(

- HISTOGRAM_NAME_AUDIO_TARGET_BITRATE_IN_KBPS,

- codec_owner_.SpeechEncoder()->GetTargetBitrate() / 1000);

send_codec_inst_.rate = send_codec.rate;

}