Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Issue 1200833002: Reland "Added ACM_dump protobuf, class for reading/writing and..." (Closed)

Created:
5 years, 6 months ago by ivoc
Modified:
5 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Added ACM_dump protobuf, class for reading/writing and...", commit e9bdfd859c309991b4ea759587f39eecdbd42bd4. Changed the BUILD.gn file that was lacking some necessary items which caused Chromium to break. Original review: https://webrtc-codereview.appspot.com/52059005/ The revert of the original CL was commit 7a75415419cbd52d798f9226010e9190e1cbad53. BUG=webrtc:4741 R=henrik.lundin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/747d5f62684e333f3a58a14f517d2ff327e088cf

Patch Set 1 : Original patch #

Patch Set 2 : Fix for gn build file, so it no longer breaks Chromium. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 chunks +30 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/acm_dump.h View 1 chunk +59 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/acm_dump.cc View 1 chunk +220 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/acm_dump_unittest.cc View 1 chunk +117 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi View 1 chunk +28 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/dump.proto View 1 chunk +78 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
ivoc
Hi guys, please have another look at the CL, this is a small fix that ...
5 years, 6 months ago (2015-06-22 11:24:56 UTC) #2
hlundin-webrtc
lgtm
5 years, 6 months ago (2015-06-22 12:29:58 UTC) #3
Andrew MacDonald
lgtm I had a few minor comments after you landed the last CL. You might ...
5 years, 6 months ago (2015-06-22 15:57:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200833002/2
5 years, 6 months ago (2015-06-23 06:38:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19)
5 years, 6 months ago (2015-06-23 06:40:42 UTC) #8
ivoc
5 years, 6 months ago (2015-06-23 08:08:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:2) manually as
747d5f62684e333f3a58a14f517d2ff327e088cf.

Powered by Google App Engine
This is Rietveld 408576698