Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1194773002: Re-enable WebRtcIsacfix_AllpassFilter2FixDec16Neon (Closed)

Created:
5 years, 6 months ago by zhongwei
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable WebRtcIsacfix_AllpassFilter2FixDec16Neon WebRtcIsacfix_AllpassFilter2FixDec16Neon was disabled due to a Clang bug. The bug is fixed in current Clang version, re-enable it in this patch. BUG=4567 R=andrew@webrtc.org, kjellander@webrtc.org TEST=buildbot build Change-Id: I71e309cec6caf376181cf9c299c9e8967c9a328e Committed: https://chromium.googlesource.com/external/webrtc/+/b3cc77f4baea230bd815a0d696969fd5e9e9f4ba

Patch Set 1 #

Patch Set 2 : update build file #

Patch Set 3 : Rebase. #

Total comments: 2

Patch Set 4 : remove lto block in isacfix.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isacfix.gypi View 1 2 3 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
zhongwei
5 years, 6 months ago (2015-06-19 08:19:33 UTC) #1
Andrew MacDonald
Sorry for the delay. lgtm.
5 years, 5 months ago (2015-07-25 03:16:04 UTC) #2
Andrew MacDonald
(and no need to wait for Henrik's approval; he's on vacation)
5 years, 5 months ago (2015-07-25 03:16:21 UTC) #3
zhongwei
On 2015/07/25 03:16:04, andrew wrote: > Sorry for the delay. lgtm. Never mind, I also ...
5 years, 4 months ago (2015-07-27 07:43:11 UTC) #4
Andrew MacDonald
https://codereview.webrtc.org/1194773002/diff/40001/webrtc/modules/audio_coding/codecs/isac/isacfix.gypi File webrtc/modules/audio_coding/codecs/isac/isacfix.gypi (right): https://codereview.webrtc.org/1194773002/diff/40001/webrtc/modules/audio_coding/codecs/isac/isacfix.gypi#newcode146 webrtc/modules/audio_coding/codecs/isac/isacfix.gypi:146: # Disable LTO in isac_neon target due to compiler ...
5 years, 4 months ago (2015-07-27 17:14:04 UTC) #5
zhongwei
https://codereview.webrtc.org/1194773002/diff/40001/webrtc/modules/audio_coding/codecs/isac/isacfix.gypi File webrtc/modules/audio_coding/codecs/isac/isacfix.gypi (right): https://codereview.webrtc.org/1194773002/diff/40001/webrtc/modules/audio_coding/codecs/isac/isacfix.gypi#newcode146 webrtc/modules/audio_coding/codecs/isac/isacfix.gypi:146: # Disable LTO in isac_neon target due to compiler ...
5 years, 4 months ago (2015-07-28 03:01:13 UTC) #6
Andrew MacDonald
lgtm
5 years, 4 months ago (2015-07-28 03:17:00 UTC) #7
zhongwei
5 years, 4 months ago (2015-07-28 03:18:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b3cc77f4baea230bd815a0d696969fd5e9e9f4ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698