webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc - Issue 1194773002: Re-enable WebRtcIsacfix_AllpassFilter2FixDec16Neon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc

Issue 1194773002: Re-enable WebRtcIsacfix_AllpassFilter2FixDec16Neon (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: remove lto block in isacfix.gypi Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc

index 8ef05e897b6d086a3a9811e4ac07468fdeac1630..80fb3929b9f9926d5352976c11cf655c6dc70028 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc

@@ -64,11 +64,6 @@ class FilterBanksTest : public testing::Test {

TEST_F(FilterBanksTest, AllpassFilter2FixDec16Test) {

CalculateResidualEnergyTester(WebRtcIsacfix_AllpassFilter2FixDec16C);

-// Disable AllpassFilter2FixDec16Neon function due to a clang bug.

-// Refer more details at:

-// https://code.google.com/p/webrtc/issues/detail?id=4567

-#if !(defined __clang__) || !defined(WEBRTC_ARCH_ARM64)

#ifdef WEBRTC_DETECT_NEON

if ((WebRtc_GetCPUFeaturesARM() & kCPUFeatureNEON) != 0) {

CalculateResidualEnergyTester(WebRtcIsacfix_AllpassFilter2FixDec16Neon);

@@ -76,7 +71,6 @@ TEST_F(FilterBanksTest, AllpassFilter2FixDec16Test) {

#elif defined(WEBRTC_HAS_NEON)

CalculateResidualEnergyTester(WebRtcIsacfix_AllpassFilter2FixDec16Neon);

#endif

-#endif

}

TEST_F(FilterBanksTest, HighpassFilterFixDec32Test) {