Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: webrtc/base/sslidentity_unittest.cc

Issue 1189583002: Support generation of EC keys using P256 curve and support ECDSA certs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: explicitly enable ECDSA for NSS; tolerate ECDSA and RSA certs in unittest Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/sslidentity_unittest.cc
diff --git a/webrtc/base/sslidentity_unittest.cc b/webrtc/base/sslidentity_unittest.cc
index fd754114288c1cd7a9b97bc429973df42a5ec474..5a5f32a344fec736e9299105aff115fdce7279ec 100644
--- a/webrtc/base/sslidentity_unittest.cc
+++ b/webrtc/base/sslidentity_unittest.cc
@@ -46,8 +46,10 @@ class SSLIdentityTest : public testing::Test {
}
virtual void SetUp() {
- identity1_.reset(SSLIdentity::Generate("test1"));
- identity2_.reset(SSLIdentity::Generate("test2"));
+ // Confirmed to work with KT_RSA and KT_ECDSA.
juberti1 2015/06/26 19:16:01 This needs to specifically test both KT_RSA and KT
torbjorng (webrtc) 2015/07/02 12:35:08 OK. I have fixed this and cleaned things up to av
+ identity1_.reset(SSLIdentity::Generate("test1", rtc::KT_DEFAULT));
+ // Confirmed to work with KT_RSA and KT_ECDSA.
+ identity2_.reset(SSLIdentity::Generate("test2", rtc::KT_DEFAULT));
ASSERT_TRUE(identity1_);
ASSERT_TRUE(identity2_);

Powered by Google App Engine
This is Rietveld 408576698