Support generation of EC keys using P256 curve and support ECDSA certs.

webrtc/base/sslidentity_unittest.cc

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 28 matching lines @@
 class SSLIdentityTest : public testing::Test {
  public:
   SSLIdentityTest() :
       identity1_(), identity2_() {
   }
 
   ~SSLIdentityTest() {
   }
 
   virtual void SetUp() {
-    identity1_.reset(SSLIdentity::Generate("test1"));
-    identity2_.reset(SSLIdentity::Generate("test2"));
+    // Confirmed to work with KT_RSA and KT_ECDSA.

[juberti1, 2015/06/26 19:16:01]

This needs to specifically test both KT_RSA and KT_ECDSA behavior - using
KT_DEFAULT isn't correct in this particular test.

[torbjorng (webrtc), 2015/07/02 12:35:08]

OK.  I have fixed this and cleaned things up to avoid making the
code unreadable.

Added a hardwired EC key/cert in PEM format too.  Unfortunately, I
couldn't find any NSS function for reading it (see added code comments),
so this is used only for BoringSSL.

+    identity1_.reset(SSLIdentity::Generate("test1", rtc::KT_DEFAULT));
+    // Confirmed to work with KT_RSA and KT_ECDSA.
+    identity2_.reset(SSLIdentity::Generate("test2", rtc::KT_DEFAULT));
 
     ASSERT_TRUE(identity1_);
     ASSERT_TRUE(identity2_);
 
     test_cert_.reset(
         rtc::SSLCertificate::FromPEMString(kTestCertificate));
     ASSERT_TRUE(test_cert_);
   }
 
   void TestGetSignatureDigestAlgorithm() {
     std::string digest_algorithm;
     // Both NSSIdentity::Generate and OpenSSLIdentity::Generate are

[juberti1, 2015/06/26 19:16:01]

comment is incorrect

     // hard-coded to generate RSA-SHA256 certificates.
     ASSERT_TRUE(identity1_->certificate().GetSignatureDigestAlgorithm(
         &digest_algorithm));
     ASSERT_EQ(rtc::DIGEST_SHA_256, digest_algorithm);
     ASSERT_TRUE(identity2_->certificate().GetSignatureDigestAlgorithm(
         &digest_algorithm));
     ASSERT_EQ(rtc::DIGEST_SHA_256, digest_algorithm);
 
     // The test certificate has an MD5-based signature.
     ASSERT_TRUE(test_cert_->GetSignatureDigestAlgorithm(&digest_algorithm));
@@ skipping 118 matching lines @@
   EXPECT_TRUE(SSLIdentity::PemToDer("CERTIFICATE", kTestCertificate, &der));
 
   EXPECT_EQ(kTestCertificate, SSLIdentity::DerToPem(
       "CERTIFICATE",
       reinterpret_cast<const unsigned char*>(der.data()), der.length()));
 }
 
 TEST_F(SSLIdentityTest, GetSignatureDigestAlgorithm) {
   TestGetSignatureDigestAlgorithm();
 }