Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1186083002: Ability to specify KeyType (RSA, ECDSA) in CreatePeerConnection (Closed)

Created:
5 years, 6 months ago by hbos
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

THE FOLLOWING CL MAKES THIS CL OBSOLETE: https://codereview.webrtc.org/1269843005/ --- The KeyType is passed around as follows in libjingle: PeerConnectionFactory::CreatePeerConnection -> PeerConnection::Initialize -> WebRtcSession::Initialize -> WebRtcSessionDescriptionFactory::WebRtcSessionDescriptionFactory The KeyType will be used to generate an SSLIdentity. It will become relevant once these CLs lands: https://codereview.webrtc.org/1176383004 https://codereview.webrtc.org/1189583002

Patch Set 1 #

Patch Set 2 : Making iOS/Mac compile #

Patch Set 3 : PeerConnectionFactoryInterface::CreatePeerConnection without KeyType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -14 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnection.mm View 1 2 chunks +5 lines, -3 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 2 chunks +2 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnectionfactory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory_unittest.cc View 8 chunks +9 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnectionfactoryproxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 2 3 chunks +29 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/proxy.h View 3 chunks +42 lines, -0 lines 0 comments Download
M talk/app/webrtc/test/peerconnectiontestwrapper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession.h View 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M talk/examples/peerconnection/client/conductor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/sslidentity.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hbos
The passing around of KeyType-related changes of https://codereview.webrtc.org/1151943005/.
5 years, 6 months ago (2015-06-15 12:37:34 UTC) #2
hbos
I should probably temporarily add a PeerConnectionFactoryInterface::CreatePeerConnection which does not take a KeyType to avoid ...
5 years, 6 months ago (2015-06-15 12:54:41 UTC) #3
hbos
PTAL tommi. (I realized I could have made CreatePeerConnection's KeyType a param with a default ...
5 years, 6 months ago (2015-06-16 07:50:34 UTC) #4
hbos
PTAL magjed, maybe you can review and then help me land this? I'm OOO for ...
5 years, 6 months ago (2015-06-18 09:52:53 UTC) #7
hbos
5 years, 4 months ago (2015-08-04 12:54:56 UTC) #8
This CL has probably become obsolete. I will close it shortly.

Powered by Google App Engine
This is Rietveld 408576698