Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1180623005: Update encoder settings periodically, not only on new bandwidth estimate (Closed)

Created:
5 years, 6 months ago by sprang_webrtc
Modified:
5 years, 6 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
stefan-webrtc, tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update encoder settings periodically, not only on new bandwidth estimate Also moved actual update call to encoder thread, and tweaked frame rate estimate to be less noisy. This is a re-upload of https://review.webrtc.org/47249004 BUG=chromium:476469 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/66a641a9c67333a344563bf0ee88e6db7ca26fba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -19 lines) Patch
M webrtc/modules/video_coding/main/source/media_optimization.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_coding_impl.h View 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender.cc View 4 chunks +38 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender_unittest.cc View 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sprang_webrtc
Re-upload, please re-lgtm!
5 years, 6 months ago (2015-06-11 11:23:32 UTC) #2
stefan-webrtc
lgtm
5 years, 6 months ago (2015-06-11 11:50:57 UTC) #3
sprang_webrtc
Committed patchset #1 (id:1) manually as 66a641a9c67333a344563bf0ee88e6db7ca26fba (presubmit successful).
5 years, 6 months ago (2015-06-11 12:20:23 UTC) #4
mflodman
Why was this re-uploaded? LGTM still, just wondering :)
5 years, 6 months ago (2015-06-21 19:01:52 UTC) #6
sprang_webrtc
On 2015/06/21 19:01:52, mflodman wrote: > Why was this re-uploaded? > > LGTM still, just ...
5 years, 6 months ago (2015-06-22 07:50:20 UTC) #7
mflodman
5 years, 6 months ago (2015-06-22 08:14:47 UTC) #8
Message was sent while issue was closed.
On 2015/06/22 07:50:20, språng wrote:
> On 2015/06/21 19:01:52, mflodman wrote:
> > Why was this re-uploaded?
> > 
> > LGTM still, just wondering :)
> 
> Rietveld change... Had trouble running try-jobs.

Ah!

Can you close the old CL to get it out of the review lists?

Powered by Google App Engine
This is Rietveld 408576698