webrtc/modules/video_coding/main/source/media_optimization.cc - Issue 1180623005: Update encoder settings periodically, not only on new bandwidth estimate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/main/source/media_optimization.cc

Issue 1180623005: Update encoder settings periodically, not only on new bandwidth estimate (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/main/source/media_optimization.h ('k') | webrtc/modules/video_coding/main/source/video_coding_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/main/source/media_optimization.cc

diff --git a/webrtc/modules/video_coding/main/source/media_optimization.cc b/webrtc/modules/video_coding/main/source/media_optimization.cc

index 524a7b2b70a080279f21b8ae79b4b56471d460e9..4dbdf44d588897fe1424e1021ecf9ff9fc69c1ad 100644

--- a/webrtc/modules/video_coding/main/source/media_optimization.cc

+++ b/webrtc/modules/video_coding/main/source/media_optimization.cc

@@ -631,8 +631,9 @@ void MediaOptimization::ProcessIncomingFrameRate(int64_t now) {

}

if (num > 1) {

- const int64_t diff = now - incoming_frame_times_[num - 1];

- incoming_frame_rate_ = 1.0;

+ const int64_t diff =

+ incoming_frame_times_[0] - incoming_frame_times_[num - 1];

+ incoming_frame_rate_ = 0.0; // No frame rate estimate available.

if (diff > 0) {

incoming_frame_rate_ = nr_of_frames * 1000.0f / static_cast<float>(diff);

}