Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1178043005: Restore rows() and cols() in aligned_array.h (Closed)

Created:
5 years, 6 months ago by kjellander_webrtc
Modified:
5 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Andrew MacDonald, mflodman, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restore rows() and cols() in aligned_array.h These getters were removed in https://codereview.webrtc.org/1172163004 but are used in external code, so it makes sense to keep them around to make the class more useful. R=henrikg@webrtc.org, pkasting@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/e8d191f00fff1ed3574d6a9d7e6d62b1acb5d5d3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M webrtc/system_wrappers/interface/aligned_array.h View 2 chunks +8 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/aligned_array_unittest.cc View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
kjellander_webrtc
5 years, 6 months ago (2015-06-18 08:22:00 UTC) #2
andresp
On 2015/06/18 08:22:00, kjellander (webrtc) wrote: Please wait for pkasting approval. Specially we want to ...
5 years, 6 months ago (2015-06-18 08:34:35 UTC) #4
Henrik Grunell WebRTC
lgtm
5 years, 6 months ago (2015-06-18 09:02:35 UTC) #5
Peter Kasting
https://codereview.webrtc.org/1178043005/diff/1/webrtc/system_wrappers/source/aligned_array_unittest.cc File webrtc/system_wrappers/source/aligned_array_unittest.cc (right): https://codereview.webrtc.org/1178043005/diff/1/webrtc/system_wrappers/source/aligned_array_unittest.cc#newcode56 webrtc/system_wrappers/source/aligned_array_unittest.cc:56: ASSERT_EQ(arr.rows(), 10); Nit: (expected, actual) (2 places)
5 years, 6 months ago (2015-06-18 16:22:48 UTC) #6
Peter Kasting
On 2015/06/18 08:34:35, andresp1 wrote: > On 2015/06/18 08:22:00, kjellander (webrtc) wrote: > > Please ...
5 years, 6 months ago (2015-06-18 16:23:42 UTC) #7
kjellander_webrtc
5 years, 6 months ago (2015-06-20 18:11:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8d191f00fff1ed3574d6a9d7e6d62b1acb5d5d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698