Issue 1172163004:
Reformat existing code. There should be no functional effects. (Closed)
Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Resync
Created 5 years, 6 months ago
Use n/p to move between diff chunks;
N/P to move between comments.
Draft comments are only viewable by you.
@@ -68,14 +68,6 @@ template<typename T> class AlignedArray {
return Row(row)[col];
}
- int rows() const {
Ben Chan
2015/06/17 14:48:56
As a helper class, the rows() and cols() getters s
As a helper class, the rows() and cols() getters seem quite useful. This class
doesn't provide any iterator interface, which means a user of this class likely
needs to memorize the number of rows and columns separately. It seems the
benefit of keeping these two getters outweighs the cost, if any.
Peter Kasting
2015/06/17 19:47:29
No one called these. I have no opposition to addi
On 2015/06/17 14:48:56, Ben Chan wrote:
> As a helper class, the rows() and cols() getters seem quite useful. This class
> doesn't provide any iterator interface, which means a user of this class
likely
> needs to memorize the number of rows and columns separately. It seems the
> benefit of keeping these two getters outweighs the cost, if any.
No one called these. I have no opposition to adding them in the future if
someone wants to call them, but if they're simply unused I don't think they
should be publicly visible.
kjellander_webrtc
2015/06/18 08:22:46
Since it seems there's code that uses them outside
On 2015/06/17 19:47:29, Peter Kasting wrote:
> On 2015/06/17 14:48:56, Ben Chan wrote:
> > As a helper class, the rows() and cols() getters seem quite useful. This
class
> > doesn't provide any iterator interface, which means a user of this class
> likely
> > needs to memorize the number of rows and columns separately. It seems the
> > benefit of keeping these two getters outweighs the cost, if any.
>
> No one called these. I have no opposition to adding them in the future if
> someone wants to call them, but if they're simply unused I don't think they
> should be publicly visible.
Issue 1172163004: Reformat existing code. There should be no functional effects.
(Closed)
Created 5 years, 6 months ago by Peter Kasting
Modified 5 years, 6 months ago
Reviewers: juberti1, Andrew MacDonald, åsapersson, henrika_webrtc, kjellander_webrtc, kwiberg-webrtc, jiayl, Ben Chan
Base URL: https://chromium.googlesource.com/external/webrtc@master
Comments: 21