Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170723002: Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender (Closed)

Created:
5 years, 6 months ago by sprang_webrtc
Modified:
5 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender BUG=2450 R=asapersson@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/bdc0b0d869e9a14bbfafcbb84e294a13383e6fa6

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed comments #

Total comments: 2

Patch Set 3 : Truncate based on rtcp packet output for rr #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -218 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 11 chunks +15 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 4 chunks +8 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 10 chunks +73 lines, -165 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sprang_webrtc
5 years, 6 months ago (2015-06-08 09:04:35 UTC) #2
åsapersson
https://codereview.webrtc.org/1170723002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right): https://codereview.webrtc.org/1170723002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode481 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:481: CriticalSectionScoped lock(critical_section_rtcp_sender_.get()); lock already taken? https://codereview.webrtc.org/1170723002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode499 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:499: // sanity ...
5 years, 6 months ago (2015-06-12 08:16:24 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1170723002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right): https://codereview.webrtc.org/1170723002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode481 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:481: CriticalSectionScoped lock(critical_section_rtcp_sender_.get()); On 2015/06/12 08:16:24, asapersson wrote: > lock ...
5 years, 6 months ago (2015-06-12 09:04:32 UTC) #4
åsapersson
https://codereview.webrtc.org/1170723002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right): https://codereview.webrtc.org/1170723002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode618 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:618: return BuildResult::kTruncated; and same as for BuildSR
5 years, 6 months ago (2015-06-12 09:30:03 UTC) #5
sprang_webrtc
https://codereview.webrtc.org/1170723002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right): https://codereview.webrtc.org/1170723002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode618 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:618: return BuildResult::kTruncated; On 2015/06/12 09:30:03, asapersson wrote: > and ...
5 years, 6 months ago (2015-06-12 12:21:44 UTC) #6
åsapersson
lgtm
5 years, 6 months ago (2015-06-12 12:29:28 UTC) #7
sprang_webrtc
5 years, 6 months ago (2015-06-22 13:21:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
bdc0b0d869e9a14bbfafcbb84e294a13383e6fa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698