Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender

webrtc/modules/rtp_rtcp/source/rtcp_packet.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 792 matching lines @@
                           RtcpPacket::PacketReadyCallback* callback) const {
   while (*index + BlockLength() > max_length) {
     if (!OnBufferFull(packet, index, callback))
       return false;
   }
   CreateSenderReport(sr_, BlockToHeaderLength(BlockLength()), packet, index);
   CreateReportBlocks(report_blocks_, packet, index);
   return true;
 }
 
-bool SenderReport::WithReportBlock(ReportBlock* block) {
-  assert(block);
+bool SenderReport::WithReportBlock(const ReportBlock& block) {
   if (report_blocks_.size() >= kMaxNumberOfReportBlocks) {
     LOG(LS_WARNING) << "Max report blocks reached.";
     return false;
   }
-  report_blocks_.push_back(block->report_block_);
+  report_blocks_.push_back(block.report_block_);
   sr_.NumberOfReportBlocks = report_blocks_.size();
   return true;
 }
 
 bool ReceiverReport::Create(uint8_t* packet,
                             size_t* index,
                             size_t max_length,
                             RtcpPacket::PacketReadyCallback* callback) const {
   while (*index + BlockLength() > max_length) {
     if (!OnBufferFull(packet, index, callback))
       return false;
   }
   CreateReceiverReport(rr_, BlockToHeaderLength(BlockLength()), packet, index);
   CreateReportBlocks(report_blocks_, packet, index);
   return true;
 }
 
-bool ReceiverReport::WithReportBlock(ReportBlock* block) {
-  assert(block);
+bool ReceiverReport::WithReportBlock(const ReportBlock& block) {
   if (report_blocks_.size() >= kMaxNumberOfReportBlocks) {
     LOG(LS_WARNING) << "Max report blocks reached.";
     return false;
   }
-  report_blocks_.push_back(block->report_block_);
+  report_blocks_.push_back(block.report_block_);
   rr_.NumberOfReportBlocks = report_blocks_.size();
   return true;
 }
 
 bool Ij::Create(uint8_t* packet,
                 size_t* index,
                 size_t max_length,
                 RtcpPacket::PacketReadyCallback* callback) const {
   while (*index + BlockLength() > max_length) {
     if (!OnBufferFull(packet, index, callback))
@@ skipping 377 matching lines @@
   return length_;
 }
 
 void RawPacket::SetLength(size_t length) {
   assert(length <= buffer_length_);
   length_ = length;
 }
 
 }  // namespace rtcp
 }  // namespace webrtc