Issue 1160403004: Add default downscale threshold to QualityScaler.

Issue 1160403004: Add default downscale threshold to QualityScaler. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc

Modified:
5 years, 6 months ago

Reviewers:
mflodman

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Add default downscale threshold to QualityScaler. Prevents downscaling below 160x90 or 90x160 to gain more quality. BUG=4625 R=mflodman@webrtc.org

Patch Set 2 : requested tests #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -19 lines)			Patch
M	webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/video_coding/utility/include/quality_scaler.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webrtc/modules/video_coding/utility/quality_scaler.cc	View		2 chunks	+12 lines, -9 lines	0 comments	Download
M	webrtc/modules/video_coding/utility/quality_scaler_unittest.cc	View	1	7 chunks	+84 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mflodman

LG, would like two more test cases though. https://codereview.webrtc.org/1160403004/diff/1/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right): https://codereview.webrtc.org/1160403004/diff/1/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc#newcode257 webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:257: Can ...

5 years, 6 months ago (2015-06-08 09:21:07 UTC) #2

pbos-webrtc

https://codereview.webrtc.org/1160403004/diff/1/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right): https://codereview.webrtc.org/1160403004/diff/1/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc#newcode257 webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:257: On 2015/06/08 09:21:06, mflodman wrote: > Can you also ...

5 years, 6 months ago (2015-06-08 13:08:23 UTC) #5

pbos-webrtc

5 years, 6 months ago (2015-06-22 06:05:47 UTC) #7

On 2015/06/22 04:13:29, mflodman wrote:
> LGTM

Landed as
https://chromium.googlesource.com/external/webrtc/+/6a688f5265040c64e49dd1624...,
I tried ctrl+c:ing because BUG=4625 should've been webrtc:4625, so this gets
incorrectly referenced. Didn't ctrl+C too quickly.

Expand Messages | Collapse Messages