Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler.cc

Issue 1160403004: Add default downscale threshold to QualityScaler. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: requested tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/utility/quality_scaler.cc
diff --git a/webrtc/modules/video_coding/utility/quality_scaler.cc b/webrtc/modules/video_coding/utility/quality_scaler.cc
index 3c9c6c4d57c92fe8585cd2907799ad0450129f73..7a2a9c02615f6d548388d95a70af2f7a6ad74936 100644
--- a/webrtc/modules/video_coding/utility/quality_scaler.cc
+++ b/webrtc/modules/video_coding/utility/quality_scaler.cc
@@ -15,9 +15,17 @@ static const int kMinFps = 10;
static const int kMeasureSeconds = 5;
static const int kFramedropPercentThreshold = 60;
+const int QualityScaler::kDefaultLowQpDenominator = 3;
+// Note that this is the same for width and height to permit 120x90 in both
+// portrait and landscape mode.
+const int QualityScaler::kDefaultMinDownscaleDimension = 90;
+
QualityScaler::QualityScaler()
- : num_samples_(0), low_qp_threshold_(-1), downscale_shift_(0),
- min_width_(0), min_height_(0) {
+ : num_samples_(0),
+ low_qp_threshold_(-1),
+ downscale_shift_(0),
+ min_width_(kDefaultMinDownscaleDimension),
+ min_height_(kDefaultMinDownscaleDimension) {
}
void QualityScaler::Init(int low_qp_threshold) {
@@ -68,18 +76,13 @@ QualityScaler::Resolution QualityScaler::GetScaledResolution(
assert(downscale_shift_ >= 0);
for (int shift = downscale_shift_;
- shift > 0 && res.width > 1 && res.height > 1;
+ shift > 0 && (res.width >> 1 >= min_width_) &&
+ (res.height >> 1 >= min_height_);
--shift) {
res.width >>= 1;
res.height >>= 1;
}
- // Set this limitation for VP8 HW encoder to avoid crash.
- if (min_width_ > 0 && res.width * res.height < min_width_ * min_height_) {
- res.width = min_width_;
- res.height = min_height_;
- }
-
return res;
}

Powered by Google App Engine
This is Rietveld 408576698