Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 1151363004: Mojo: Send Android args in a string array, not JSON. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: Send Android args in a string array, not JSON. Use adb shell am's comma-separated --esa argument. (escape commas in the script and un-escape them in Java) John was hitting a JSON parsing error/crash locally. This should circumvent that error and reduce complexity. BUG=NONE TEST=Android Mojo and Mandoline still works as expected. R=sky@chromium.org,jam@chromium.org Committed: https://crrev.com/089ac0057f850ad3a26a6bd9f86d9043c461bdbd Cr-Commit-Position: refs/heads/master@{#333018}

Patch Set 1 #

Patch Set 2 : Sync and rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -38 lines) Patch
M mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 2 chunks +5 lines, -34 lines 0 comments Download
M mojo/tools/mopy/android.py View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
msw
Hey John and Scott, please take a look; thanks!
4 years, 5 months ago (2015-06-05 00:20:33 UTC) #1
msw
(we could also apparently use JsonReader.setLenient(true) if we want a different workaround... I don't know ...
4 years, 5 months ago (2015-06-05 02:36:50 UTC) #2
jam
lgtm
4 years, 5 months ago (2015-06-05 03:53:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151363004/20001
4 years, 5 months ago (2015-06-05 05:07:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2015-06-05 06:24:42 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2015-06-05 06:25:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/089ac0057f850ad3a26a6bd9f86d9043c461bdbd
Cr-Commit-Position: refs/heads/master@{#333018}

Powered by Google App Engine
This is Rietveld 408576698