Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: device/vr/android/gvr/gvr_delegate.h

Issue 2584343002: WIP: working copy-no-compositor path
Patch Set: StatTracker destructor, delete old magic numbers, mojo export Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/android/gvr/gvr_delegate.h
diff --git a/device/vr/android/gvr/gvr_delegate.h b/device/vr/android/gvr/gvr_delegate.h
index c5e22a0927d056873060c80e81b475b4f866b61a..4405494af2d93b9d62078e1bcfc2be4b16451df5 100644
--- a/device/vr/android/gvr/gvr_delegate.h
+++ b/device/vr/android/gvr/gvr_delegate.h
@@ -6,6 +6,7 @@
#define DEVICE_VR_ANDROID_GVR_DELEGATE_H
#include "device/vr/android/gvr/gvr_device_provider.h"
+#include "device/vr/vr_device.h"
#include "device/vr/vr_export.h"
#include "third_party/gvr-android-sdk/src/libraries/headers/vr/gvr/capi/include/gvr_types.h"
@@ -15,19 +16,20 @@ class GvrApi;
namespace device {
-constexpr gvr::Sizei kInvalidRenderTargetSize = {0, 0};
+constexpr gvr::Sizei kInvalidRenderTargetSize = {1, 1};
class DEVICE_VR_EXPORT GvrDelegate {
artem.bolgar 2017/02/14 03:34:28 Shouldn't this class have a virtual dtor?
public:
virtual void SetWebVRSecureOrigin(bool secure_origin) = 0;
- virtual void SubmitWebVRFrame() = 0;
- virtual void UpdateWebVRTextureBounds(const gvr::Rectf& left_bounds,
+ virtual void SubmitWebVRFrame(int32_t surface_handle, mojom::VRPosePtr pose) = 0;
+ virtual void UpdateWebVRTextureBounds(uint32_t for_pose_index,
+ const gvr::Rectf& left_bounds,
const gvr::Rectf& right_bounds) = 0;
- virtual void SetGvrPoseForWebVr(const gvr::Mat4f& pose,
- uint32_t pose_index) = 0;
- virtual gvr::Sizei GetWebVRCompositorSurfaceSize() = 0;
- virtual void SetWebVRRenderSurfaceSize(int width, int height) = 0;
+ virtual void SetWebVRGvrPose(const gvr::Mat4f& pose,
+ uint32_t pose_index,
+ int64_t pose_time_nanos) = 0;
+ virtual void GetWebVRSurfaceHandle(int width, int height, const mojom::VRDisplay::GetSurfaceHandleCallback& callback) = 0;
virtual gvr::GvrApi* gvr_api() = 0;
};

Powered by Google App Engine
This is Rietveld 408576698