Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
2983313002	Updated status files to expect MissingCompileTimeError for static error tests on non-dart 2.0 confi… (Closed)	bkonyi	jcollins		8 hours, 27 minutes
2984893002	Removed files that were missed during migration and fixed status file. (Closed)	bkonyi	jcollins		8 hours, 49 minutes
2983253002	Migrated test block 29 to Dart 2.0 (Closed)	bkonyi	Bob Nystrom, jcollins	1	9 hours, 16 minutes
2950503002	[media-internals] Add note to clipboard dialog (Closed)	rongjie	Henrik Grunell OOO back Aug 14, tommi (sloooow) - chröme		17 hours, 22 minutes
2944523002	Improving flat containers interface. (Closed)	dyaroshev	vmpstr, danakj, jdoerrie, Nico, brettw, sky	95	17 hours, 22 minutes
2978953002	[Extensions] Don't allow content scripts on the New Tab Page (Closed)	Devlin (OOO through July 24)	karandeepb	22	22 hours, 5 minutes
785053002	[WIP] Screen Orientation OOIF (Closed)	mlamouri (slow - plz ping)	kenrb		1 day
752303003	Remove WebViewClient::speechRecognizer(). (Closed)	mlamouri (slow - plz ping)	Mike West		1 day
2958303002	[Sync] Maintain a global_id mapping to update UserEvents that references navigations (Closed)	skym	vabr (Chromium), Patrick Noland, Steven Holte	25	1 day, 4 hours
2933493003	Add viz-host HitTestQuery. (Closed)	riajiang	rjkroege, gklassen, varkha, sadrul, Fady Samuel	131	1 day, 8 hours
2978643002	Removing bad-continuation param and fixing resulting errors. Fixed indentation errors, in telemetry… (Closed)	Lo-Lo			1 day, 11 hours
2936333002	WebUI: Replace vulcanize with polymer-bundler (Closed)	dpapad	calamity, michaelpg	12	1 day, 12 hours
2991453002	Restore UriReferencedElement and its uri/uriOffset/uriEnd properties. (Closed)	scheglov	Paul Berry, Brian Wilkerson		1 day, 12 hours
2987613002	Fix gae.py's detection of current active credentials. (Closed)	Vadim Sh.	nodir, M-A Ruel		1 day, 12 hours
2823513002	[Clank] Load origin id before create MediaDrmBridge (Closed)	yucliu1	jrummell, xhwang	29	1 day, 13 hours
2981183003	fix #29766, fix #29782 - fix override checker's interface checking (Closed)	Jennifer Messerly	vsm	9	1 day, 13 hours
2979353002	implement `Invocation.typeArguments` in DDC (Closed)	Jennifer Messerly	vsm, Lasse Reichstein Nielsen	4	1 day, 13 hours
2989493002	Simplify and fix implicit closure check, speed up Closure_equals (Closed)	alexmarkov	zra, siva	13	1 day, 13 hours
2984083002	Revert "Simplify and fix implicit closure check, speed up Closure_equals" (Closed)	alexmarkov	zra, siva		1 day, 13 hours
2989513002	[VM generic functions] Disallow generic function types as type arguments or bounds. (Closed)	regis	Leaf, siva		1 day, 14 hours

1 - 20 Older ›